fix: resolve TODO to preserve TokenBucket budget during updates #5594
+113
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-ang
force-pushed
the
todo-tokenbucket
branch
3 times, most recently
from
3f2120e to
7c95a0d
Compare
aaron-ang
commented
Dec 19, 2025
|
|
||
| /// Allocate a host-side port to be assigned to a new host-initiated connection. | ||
| fn allocate_local_port(&mut self) -> u32 { | ||
| // TODO: this doesn't seem very space-efficient. |
aaron-ang
commented
Dec 19, 2025
Comment on lines
-163
to
-164
| // TODO: Refactor this to make more efficient but there are | ||
| // lifetime/ownership challenges. |
Author
There was a problem hiding this comment.
imo memcpy is already probably the most efficient way for this
aaron-ang
commented
Dec 19, 2025
| pub fn from_bytes_unchecked(src: &[u8]) -> MacAddr { | ||
| // TODO: using something like std::mem::uninitialized could avoid the extra initialization, | ||
| // if this ever becomes a performance bottleneck. | ||
| let mut bytes = [0u8; MAC_ADDR_LEN as usize]; |
Author
There was a problem hiding this comment.
initialization overhead for 6-byte buffer should be small compared to rest of network processing
aaron-ang
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
Also remove some stale TODOs and update docs. Signed-off-by: Aaron Ang <aaron.angyd@gmail.com>
aaron-ang
force-pushed
the
todo-tokenbucket
branch
from
7c95a0d to
b4c5d6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
update_buckets()preserves budget, one_time_burst, and last_update (capped at new bucket limits) instead of resetting to full capacity.Reason
Address a TODO regarding
TokenBucketupdates. See #3273.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.