Fix listDeserializer casting issue in firebase_data_connect #17895
Conversation
The `listDeserializer` function was incorrectly casting the input `data` to `List<T>`. When deserializing JSON, the input is typically `List<dynamic>`, which cannot be cast to `List<T>` (unless T is dynamic). This caused a runtime `TypeError`. This change modifies `listDeserializer` and `listSerializer` to cast the input to `List` (which is `List<dynamic>`) and rely on the `map` function to handle the type conversion, ensuring correct runtime behavior for JSON lists. Added regression tests to verify the fix and ensure type safety is maintained.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Fixed a bug in
firebase_data_connectwherelistDeserializerwould throw aTypeErrorwhen processing JSON lists because of an incorrect cast fromList<dynamic>toList<T>. ModifiedlistDeserializerandlistSerializerinoptional.dartto acceptList<dynamic>inputs. Added regression tests intest/src/optional_regression_test.dartto verify the fix.PR created automatically by Jules for task 6001879865263701345 started by @maneesht