fix: Address flaky dispatch

.github/workflows/abtesting.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseABTesting**'
     - 'Interop/Analytics/Public/*.h'
-    - '.github/workflows/abtesting.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/abtesting.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

.github/workflows/appdistribution.yml

@@ -8,8 +8,8 @@ on:
   pull_request:
     paths:
     - 'FirebaseAppDistribution**'
-    - '.github/workflows/appdistribution.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/appdistribution.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_cocoapods_cron.yml'

.github/workflows/auth.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseAuth**'
     - 'FirebaseAuth/Interop/*.h'
-    - '.github/workflows/auth.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/auth.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

.github/workflows/common.yml

@@ -52,6 +52,12 @@ on:
         required: false
         default: ""
 
+      # Whether the job is scheduled. Defaults to false.
+      is_nightly:
+        type: boolean
+        required: false
+        default: false
+
     outputs:
       cache_key:
         description: "The cache key for the Swift package resolution."
@@ -86,6 +92,8 @@ jobs:
     # Run on the main repo's scheduled jobs or pull requests and manual workflow invocations.
     if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
     needs: [spm-package-resolved]
+    env:
+        FIREBASE_IS_NIGHTLY_TESTING: ${{ inputs.is_nightly && '1' || '' }}
     strategy:
       matrix:
         os: [macos-15]
@@ -114,6 +122,8 @@ jobs:
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
       if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14'
+      env:
+        FIREBASE_IS_NIGHTLY_TESTING: ${{ inputs.is_nightly && '1' || '' }}
       with:
         timeout_minutes: 15
         max_attempts: 3

.github/workflows/core.yml

@@ -8,8 +8,8 @@ on:
   pull_request:
     paths:
     - 'FirebaseCore**'
-    - '.github/workflows/core.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/core.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_cocoapods_cron.yml'

.github/workflows/core_extension.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseCoreExtension.podspec'
     - 'FirebaseCore/Extension/**'
-    - '.github/workflows/core_extension.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/core_extension.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_cocoapods_cron.yml'
     - 'Gemfile*'

.github/workflows/core_internal.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseCoreInternal.podspec'
     - 'FirebaseCore/Internal/**'
-    - '.github/workflows/core_internal.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/core_internal.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_cocoapods_cron.yml'

.github/workflows/crashlytics.yml

@@ -10,7 +10,7 @@ on:
     - 'Crashlytics**'
     - 'FirebaseCrashlytics.podspec'
     - '.github/workflows/crashlytics.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'
@@ -30,6 +30,8 @@ jobs:
     uses: ./.github/workflows/common.yml
     with:
       target: FirebaseCrashlyticsUnit
+      # is_nightly: ${{ github.event_name == 'schedule' }}
+      is_nightly: ${{ github.event_name == 'pull_request' }}
 
   catalyst:
     uses: ./.github/workflows/common_catalyst.yml

.github/workflows/database.yml

@@ -12,8 +12,8 @@ on:
     - 'FirebaseSharedSwift**'
     - 'Example/Database/**'
     - 'FirebaseAuth/Interop/*.h'
-    - '.github/workflows/database.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/database.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

.github/workflows/firebase_app_check.yml

@@ -8,8 +8,8 @@ on:
   pull_request:
     paths:
     - 'FirebaseAppCheck**'
-    - '.github/workflows/firebase_app_check.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/firebase_app_check.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_cocoapods_cron.yml'

.github/workflows/firebaseai.yml

@@ -4,8 +4,8 @@ on:
   pull_request:
     paths:
     - 'FirebaseAI**'
-    - '.github/workflows/firebaseai.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/firebaseai.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - 'scripts/build.sh'
     - 'scripts/quickstart_build_spm.sh'

.github/workflows/firestore.yml

@@ -59,7 +59,7 @@ jobs:
               - 'FirebaseFirestore.podspec'
 
               # Package.swift
-              - 'Package.swift'
+              # - 'Package.swift'
 
               # CMake
               - '**CMakeLists.txt'
@@ -81,10 +81,10 @@ jobs:
               - 'scripts/xcresult_logs.py'
 
               # This workflow
-              - '.github/workflows/firestore.yml'
+              # - '.github/workflows/firestore.yml'
 
               # Workflows this one depends on.
-              - '.github/workflows/common.yml'
+              # - '.github/workflows/common.yml'
               - '.github/workflows/common_cocoapods.yml'
 
               # Rebuild on Ruby infrastructure changes.

.github/workflows/functions.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseFunctions**'
     - 'FirebaseSharedSwift**'
-    - '.github/workflows/functions.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/functions.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_cocoapods_cron.yml'
     - 'FirebaseAuth/Interop/*.h'

.github/workflows/inappmessaging.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseInAppMessaging**'
     - 'Interop/Analytics/Public/*.h'
-    - '.github/workflows/inappmessaging.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/inappmessaging.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_quickstart.yml'
     - '.github/workflows/common_cocoapods_cron.yml'

.github/workflows/installations.yml

@@ -8,8 +8,8 @@ on:
   pull_request:
     paths:
     - 'FirebaseInstallations**'
-    - '.github/workflows/installations.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/installations.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

.github/workflows/messaging.yml

@@ -14,9 +14,9 @@ on:
     # Podspec
     - 'FirebaseMessaging.podspec'
     # This file
-    - '.github/workflows/messaging.yml'
+    # - '.github/workflows/messaging.yml'
     # Re-usable workflows being used by this file.
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

.github/workflows/mlmodeldownloader.yml

@@ -8,8 +8,8 @@ on:
   pull_request:
     paths:
     - 'FirebaseMLModelDownloader**'
-    - '.github/workflows/mlmodeldownloader.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/mlmodeldownloader.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_cocoapods_cron.yml'

.github/workflows/performance.yml

@@ -14,9 +14,9 @@ on:
     # Podspec
     - 'FirebasePerformance.podspec'
     # YML configuration file
-    - '.github/workflows/performance.yml'
+    # - '.github/workflows/performance.yml'
     # Re-usable workflows depended on by this file.
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

.github/workflows/remoteconfig.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseRemoteConfig**'
     - 'Interop/Analytics/Public/*.h'
-    - '.github/workflows/remoteconfig.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/remoteconfig.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

.github/workflows/sessions.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseSessions**'
     - 'FirebaseSessions.podspec'
-    - '.github/workflows/sessions.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/sessions.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - 'Gemfile*'

.github/workflows/shared-swift.yml

@@ -8,8 +8,8 @@ on:
   pull_request:
     paths:
     - 'FirebaseSharedSwift**'
-    - '.github/workflows/shared-swift.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/shared-swift.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - 'Gemfile*'
 

.github/workflows/spm.yml

@@ -4,8 +4,8 @@ on:
   workflow_dispatch:
   pull_request:
     paths:
-    - '.github/workflows/spm.yml'
-    - 'Package.swift'
+    # - '.github/workflows/spm.yml'
+    # - 'Package.swift'
     - '.swiftpm/*'
     - 'scripts/build.sh'
     - 'SwiftPMTests/*'

.github/workflows/storage.yml

@@ -9,8 +9,8 @@ on:
     paths:
     - 'FirebaseStorage**'
     - 'FirebaseAuth/Interop/*.h'
-    - '.github/workflows/storage.yml'
-    - '.github/workflows/common.yml'
+    # - '.github/workflows/storage.yml'
+    # - '.github/workflows/common.yml'
     - '.github/workflows/common_cocoapods.yml'
     - '.github/workflows/common_catalyst.yml'
     - '.github/workflows/common_quickstart.yml'

Crashlytics/Crashlytics/Models/FIRCLSSettings.m

@@ -190,15 +190,21 @@ - (NSDictionary *)loadCacheKey {
 
 - (void)deleteCachedSettings {
   __weak FIRCLSSettings *weakSelf = self;
+#ifndef FIREBASE_IS_NIGHTLY_TESTING
   dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
+#else
+#error "Mango"
+#endif
     __strong FIRCLSSettings *strongSelf = weakSelf;
     if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsFilePath]) {
       [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsFilePath];
     }
     if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsCacheKeyPath]) {
       [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath];
     }
+#ifndef FIREBASE_IS_NIGHTLY_TESTING
   });
+#endif
 
   @synchronized(self) {
     self.isCacheKeyExpired = YES;

Package.swift

@@ -636,6 +636,10 @@ let package = Package(
       ],
       cSettings: [
         .headerSearchPath("../.."),
+        .define(
+          "FIREBASE_IS_NIGHTLY_TESTING",
+          to: Context.environment["FIREBASE_IS_NIGHTLY_TESTING", default: ""]
+        ),
         .define("DISPLAY_VERSION", to: firebaseVersion),
         .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])),
         .define(