Skip to content

infra: Fix firebaseai job in zip.yml #15574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 7 commits into from
Dec 3, 2025
Merged

infra: Fix firebaseai job in zip.yml #15574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
13dc131
infra: Fix firebaseai job in zip.yml
ncooke3 Dec 3, 2025
b6a7ddf
Apply suggestion from @ncooke3
ncooke3 Dec 3, 2025
badd7e2
maybe
ncooke3 Dec 3, 2025
977bdc9
Apply suggestion from @ncooke3
ncooke3 Dec 3, 2025
adce21b
Apply suggestion from @ncooke3
ncooke3 Dec 3, 2025
6cbfaac
work
ncooke3 Dec 3, 2025
bbbaf7b
zip
ncooke3 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/zip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,8 +357,7 @@ jobs:
env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
SDK: "FirebaseAI"
# This is a workaround to use the FirebaseAIExampleZip scheme that does not have the SPM dependency.
SWIFT_SUFFIX: "Zip"
SWIFT_SUFFIX: " (iOS)"
strategy:
matrix:
artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic]
Expand All @@ -385,7 +384,7 @@ jobs:
find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} +
- uses: actions/checkout@v4
- name: Setup quickstart
run: SAMPLE="$SDK" TARGET="${SDK}ExampleZip" scripts/setup_quickstart_framework.sh \
run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \
"${HOME}"/ios_frameworks/Firebase/FirebaseAILogic/* \
"${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/*
- name: Install Secret GoogleService-Info.plist
Expand Down
6 changes: 1 addition & 5 deletions scripts/test_quickstart_framework.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,5 @@ source scripts/check_secrets.sh

if check_secrets; then
cd quickstart-ios
if [ "$platform" = "swift" ]; then
have_secrets=true SAMPLE="$sample" SWIFT_SUFFIX="Swift" "${REPO}"/scripts/zip_quickstart_test.sh
else
have_secrets=true SAMPLE="$sample" "${REPO}"/scripts/zip_quickstart_test.sh
fi
have_secrets=true SAMPLE="$sample" "${REPO}"/scripts/zip_quickstart_test.sh
fi
6 changes: 1 addition & 5 deletions scripts/zip_quickstart_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ EXIT_STATUS=0

cd "${SAMPLE}"

if [[ ! -z "$LEGACY" ]]; then
cd "Legacy${SAMPLE}Quickstart"
fi

xcode_version=$(xcodebuild -version | grep Xcode)
xcode_version="${xcode_version/Xcode /}"
xcode_major="${xcode_version/.*/}"
Expand Down Expand Up @@ -58,7 +54,7 @@ fi
(
xcodebuild \
-project ${PROJECT_NAME} \
-scheme ${SCHEME_NAME} \
-scheme "${SCHEME_NAME}" \
-destination "platform=iOS Simulator,name=$device_name" "SWIFT_VERSION=5.3" "OTHER_LDFLAGS=\$(OTHER_LDFLAGS) -ObjC" "FRAMEWORK_SEARCH_PATHS= \$(PROJECT_DIR)/Firebase/" HEADER_SEARCH_PATHS='$(inherited) $(PROJECT_DIR)/Firebase' \
build \
) || EXIT_STATUS=$?
Expand Down
Loading