-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Realtime pipeline public preview #15525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cheryl/AddExprAsBool
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
Generated by 🚫 Danger |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request makes the realtime pipeline feature public. This involves changing several Swift APIs from internal to public and includes a significant, well-structured refactoring of the C++ expression evaluation logic. The new create(from: Query) function is a great addition for converting standard queries to pipelines.
My main feedback is to improve the safety of the new create(from:) method in RealtimePipelineSource.swift by replacing forced casts and fatalError with proper error handling, which is crucial for a public API. I also found a minor typo in a new test name.
The C++ refactoring is a great improvement, making the expression evaluation logic more modular and readable. The renaming of functions like lt to less_than and eq to equal enhances clarity.
Overall, this is a solid PR that makes a powerful feature available to users.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.