Skip to content

Conversation

@andrewheard
Copy link
Contributor

Updated build.sh to use the xcodebuild actions build-for-testing and test-without-building (instead of build and test) for the integration tests. This may speed up the GHA since test seems to rebuild.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review November 14, 2025 15:54
@andrewheard andrewheard requested review from ncooke3 and paulb777 and removed request for ncooke3 November 14, 2025 15:55
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@paulb777
Copy link
Member

Please touch Gemfile to force a full rebuild to verify this works across all CI.

@andrewheard
Copy link
Contributor Author

Please touch Gemfile to force a full rebuild to verify this works across all CI.

Now in progress. One thing to note, since it may be be clear from the default diff view, this only touches the FirebaseAIIntegration-*-*) section of build.sh:

  FirebaseAIIntegration-*-*)
    # Build
    RunXcodebuild \
      -project 'FirebaseAI/Tests/TestApp/FirebaseAITestApp.xcodeproj' \
      -scheme "FirebaseAITestApp-SPM" \
      "${xcb_flags[@]}" \
      build-for-testing

    # Run tests
    RunXcodebuild \
      -project 'FirebaseAI/Tests/TestApp/FirebaseAITestApp.xcodeproj' \
      -scheme "FirebaseAITestApp-SPM" \
      "${xcb_flags[@]}" \
      -parallel-testing-enabled NO \
      -retry-tests-on-failure \
      -test-iterations 3 \
      test-without-building
    ;;

@paulb777
Copy link
Member

Oh sorry. I missed the context that it was only for AI Logic. I'm fine to revert the Gemfile change and merge. We can update other products later.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reverting Gemfile

@andrewheard andrewheard merged commit 54ae013 into main Nov 14, 2025
98 checks passed
@andrewheard andrewheard deleted the ah/ai-integration-test-building branch November 14, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants