Skip to content

Reduce Android minSdkVersion back to 23 #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Reduce Android minSdkVersion back to 23 #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06bdfd3
Try reducing the minSdkVersion to 23
a-maurice Oct 8, 2024
7eb5b87
Specify a different r8 tools version
a-maurice Oct 8, 2024
c6f6c38
Update firestore internal test
a-maurice Oct 8, 2024
a294869
Merge branch 'main' into am-minSdkVersion
a-maurice Oct 9, 2024
b635916
Update readme
a-maurice Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analytics/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
5 changes: 4 additions & 1 deletion analytics/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.android.analytics.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion app/app_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
2 changes: 1 addition & 1 deletion app/google_api_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
5 changes: 4 additions & 1 deletion app/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.android.analytics.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion app/invites_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
2 changes: 1 addition & 1 deletion app/test_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
2 changes: 1 addition & 1 deletion app_check/app_check_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
2 changes: 1 addition & 1 deletion app_check/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
5 changes: 4 additions & 1 deletion app_check/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.firebase.cpp.appcheck.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion auth/auth_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
2 changes: 1 addition & 1 deletion auth/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
5 changes: 4 additions & 1 deletion auth/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.android.auth.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion database/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
2 changes: 1 addition & 1 deletion database/database_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
5 changes: 4 additions & 1 deletion database/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.firebase.cpp.database.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion dynamic_links/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
5 changes: 4 additions & 1 deletion dynamic_links/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.android.dynamiclinks.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion firestore/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ android {

defaultConfig {
// Jelly Bean is the minimum supported version needed by Firebase.
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
2 changes: 1 addition & 1 deletion firestore/firestore_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
5 changes: 4 additions & 1 deletion firestore/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.firebase.cpp.firestore.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
5 changes: 4 additions & 1 deletion firestore/integration_test_internal/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -63,7 +66,7 @@ android {

defaultConfig {
applicationId 'com.google.firebase.cpp.firestore.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion functions/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
5 changes: 4 additions & 1 deletion functions/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.firebase.cpp.functions.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion gma/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
2 changes: 1 addition & 1 deletion gma/gma_resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ android {
buildToolsVersion '32.0.0'

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
}

Expand Down
5 changes: 4 additions & 1 deletion gma/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.android.admob.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion installations/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
5 changes: 4 additions & 1 deletion installations/integration_test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
// r8 on this version of the Android tools has a bug,
// so specify a different version to use.
classpath 'com.android.tools:r8:8.3.37'
classpath 'com.google.gms:google-services:4.4.1'
}
}
Expand Down Expand Up @@ -55,7 +58,7 @@ android {

defaultConfig {
applicationId 'com.google.firebase.fis.testapp'
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName '1.0'
Expand Down
2 changes: 1 addition & 1 deletion messaging/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

defaultConfig {
minSdkVersion 24
minSdkVersion 23
targetSdkVersion 34
versionCode 1
versionName "1.0"
Expand Down
Loading
Loading