Skip to content

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Dec 27, 2025

  • moved overlay handling in separate js-file
  • migrated mobileMenu overlay to the global one
  • refactored closeOverlay handling

ℹ️ i’ve decided to close all elements when clicking on the overlay. there is another option, if we wanna handle it different.

Resolves #349

@github-actions
Copy link

github-actions bot commented Dec 27, 2025

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link

netlify bot commented Dec 27, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 4abb6ca
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/6950170d3893fa0008117234
😎 Deploy Preview https://deploy-preview-547--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@therobrob therobrob marked this pull request as ready for review December 27, 2025 14:04
@therobrob therobrob added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label Dec 27, 2025
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification of the code base. I noticed just one small regression, which we should address.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mobile menu overlay should also cover the logo and the search icon. While the search item issue can easily be fixed by adding a higher z-index, the header bar / logo issue is more complex. In the current DOM structure, we can't hide it via the z-index because the z-index is inherited to children (and can't be higher than the parent). Since the nav element is part of the header, it can't have a higher z-index. We would need to move it out.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unite overlay implementations

3 participants