-
-
Notifications
You must be signed in to change notification settings - Fork 17
feat: unite overlay implementations #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MoritzWeber0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the simplification of the code base. I noticed just one small regression, which we should address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mobile menu overlay should also cover the logo and the search icon. While the search item issue can easily be fixed by adding a higher z-index, the header bar / logo issue is more complex. In the current DOM structure, we can't hide it via the z-index because the z-index is inherited to children (and can't be higher than the parent). Since the nav element is part of the header, it can't have a higher z-index. We would need to move it out.
ℹ️ i’ve decided to close all elements when clicking on the overlay. there is another option, if we wanna handle it different.
Resolves #349