chore(docs): remove unused ApiDefinitionHolderLatest and getApiLatestToNavigationNodeUrlSlug #10807
+0
−388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes dead code from the docs-resolver package that was only used in skipped tests.
Link to Devin run: https://app.devin.ai/sessions/f234aee3699e4d81b98b4c75af64ea73
Requested by: danny@buildwithfern.com (@dannysheridan)
Changes Made
ApiDefinitionHolderLatestclass (110 lines) - a duplicate implementation for resolving API definitions using FDR's "latest" API formatgetApiLatestToNavigationNodeUrlSlugutility function (12 lines) - slug generation for the "latest" API formatTotal: 388 lines of dead code removed
Key Review Points
ApiDefinitionHolderLatestorgetApiLatestToNavigationNodeUrlSlug(I verified with ripgrep but a second check is valuable)ApiDefinitionHolderclass (without "Latest" suffix) provides all necessary functionalityThe removed code appears to be an abandoned implementation that was never integrated into production. All tests were skipped (
it.skip), suggesting this was experimental or incomplete work.Testing
rgpnpm run check- all lint checks pass