Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 23, 2025

Description

This PR removes dead code from the docs-resolver package that was only used in skipped tests.

Link to Devin run: https://app.devin.ai/sessions/f234aee3699e4d81b98b4c75af64ea73
Requested by: danny@buildwithfern.com (@dannysheridan)

Changes Made

  • Removed ApiDefinitionHolderLatest class (110 lines) - a duplicate implementation for resolving API definitions using FDR's "latest" API format
  • Removed getApiLatestToNavigationNodeUrlSlug utility function (12 lines) - slug generation for the "latest" API format
  • Removed associated test files with skipped tests (266 lines total)

Total: 388 lines of dead code removed

Key Review Points

⚠️ Important: Please verify:

  1. No production code references ApiDefinitionHolderLatest or getApiLatestToNavigationNodeUrlSlug (I verified with ripgrep but a second check is valuable)
  2. The actively used ApiDefinitionHolder class (without "Latest" suffix) provides all necessary functionality
  3. There are no plans to migrate to FDR's "latest" API format that would require this code

The removed code appears to be an abandoned implementation that was never integrated into production. All tests were skipped (it.skip), suggesting this was experimental or incomplete work.

Testing

  • Verified no references exist outside of the deleted files using rg
  • Ran pnpm run check - all lint checks pass
  • CI will verify no compilation errors or test failures

…ApiLatestToNavigationNodeUrlSlug

Co-Authored-By: danny@buildwithfern.com <danny@buildwithfern.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant