Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 22, 2025

Description

Devin Session: https://app.devin.ai/sessions/d14dcd6ae18740ceaa6ee41d3279a9e5
Requested by: Catherine Deskur (catherine@buildwithfern.com)

This PR adds comprehensive documentation about fixture testing requirements to help contributors understand when and how to include test fixtures with their code changes. The guidance emphasizes that fixture testing is a critical requirement for all code changes in the repository.

Changes Made

  • Added new "Testing Changes with Fixtures" section to CLAUDE.md with detailed guidance on:
    • When to add/update fixtures (new features, bug fixes, behavior changes, IR changes, CLI features)
    • Step-by-step workflow for testing with fixtures
    • Best practices for fixture testing
    • Common testing patterns with examples
  • Updated CONTRIBUTING.md with a concise "Important: Always Include Fixtures to Test Changes" section
  • Added cross-references between the two documentation files
  • Updated "Development Notes" section to reference the new fixture testing guidance

Testing

  • Verified lint checks pass (pnpm run check)
  • Reviewed documentation for accuracy against existing codebase structure
  • Ensured commands and file paths match repository conventions
  • Confirmed consistency with existing documentation style

Review Checklist

Please verify:

  • Commands and file paths are accurate (e.g., /test-definitions/fern/apis/, seed/<generator>/seed.yml)
  • Workflow steps match actual development practices in the repository
  • Examples are realistic and helpful for contributors
  • Guidance doesn't conflict with other documentation sections
  • "When to add fixtures" scenarios cover the main use cases developers encounter

Co-Authored-By: Catherine Deskur <catherine@buildwithfern.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: Catherine Deskur <catherine@buildwithfern.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants