fix(docs): add color-scheme hint to signal native dark mode support #5521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: stephen@buildwithfern.com <stephen@buildwithfern.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
🌱 Smoke Test PreviewTesting branch changes with smoke test content:
🕷️ Smoke Test Crawler ResultsPages crawled: 33 🎉 All pages loaded successfully with no errors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes made
Adds
color-scheme: light dark;to thehtmlelement to signal to browsers that the site natively supports both light and dark color schemes.What was the motivation & context behind this PR?
Users reported that Comet browser's built-in dark mode injection causes stale theme values, specifically affecting
.prosetext color. Comet injects stylesheets to add dark mode for sites that don't natively support it, but our class-based theming system (.dark/.lightclasses) wasn't being recognized.The
color-schemeCSS property tells browsers "this site already handles dark mode" which should prevent Comet from trying to force its own dark mode overrides.How has this PR been tested?
Human review checklist
color-scheme)Link to Devin run: https://app.devin.ai/sessions/d197d679750a472d88233ca0803ea5e8
Requested by: stephen@buildwithfern.com