-
Notifications
You must be signed in to change notification settings - Fork 0
Align grammar rules with TNFR physics: add RC3 (phase verification) and RC4 (bifurcation limits) #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Align grammar rules with TNFR physics: add RC3 (phase verification) and RC4 (bifurcation limits) #2823
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f131b7b
Initial plan
Copilot b019481
Complete analysis: identify RC3 and RC4 as emergent canonical rules
Copilot 6c56085
Implement RC3 (Phase Verification) as canonical grammar rule
Copilot 9233802
Update CANONICAL_SUMMARY.md with RC3 and RC4
Copilot de331ab
Final summary: grammar rules now correspond exactly to TNFR physics
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent implementation claim: Lines 72-73 state that RC3 is "Añadido a
canonical_grammar.py::validate_phase_compatibility()", but this is misleading. The function was added, but it only serves as documentation/awareness - it always returnsTrueand doesn't actually validate phase compatibility. The real validation happens invalidate_coupling()via theUM_STRICT_PHASE_CHECKflag.This should be clarified as:
canonical_grammar.py::validate_phase_compatibility()(regla de documentación)validate_coupling()conUM_STRICT_PHASE_CHECK=True