Skip to content

Correct effective degrees of freedom computation for fpca_direct #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Correct effective degrees of freedom computation for fpca_direct #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fdaPDE/src/models/fpca.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ template <typename VariationalSolver> class fpca_direct_impl {
double gcv_(const matrix_t& X, int rank, const LambdaT lambda, int flag) {
const auto& [F, S] = solve_(X, rank, lambda, flag);
// evaluate GCV index at convergence (note that Tr[S] = \|D^(-1)\|_F^2)
int dor = n_locs_ - invD_.squaredNorm();
int dor = n_locs_ - (invD_*smoother_->Psi().transpose()).squaredNorm();
return (n_locs_ / std::pow(dor, 2)) * (X.transpose() * S - (smoother_->Psi() * F)).squaredNorm();
}
int n_locs_ = 0, n_units_ = 0, n_dofs_ = 0;
Expand Down