Skip to content

Added Error to return type of async validator #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 2 commits into from
May 4, 2022
Merged

Added Error to return type of async validator #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ae731
Added Error to return type of async validator
vjau May 3, 2022
062f6d2
Split the promise validator tsd test
vjau May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export interface FastifyBasicAuthOptions {
req: FastifyRequest,
reply: FastifyReply,
done: (err?: Error) => void
): void | Promise<void>;
): void | Promise<void|Error>;
authenticate?: boolean | { realm: string };
header?: string;
}
Expand Down
16 changes: 16 additions & 0 deletions index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import fastifyBasicAuth from '.'

const app = fastify()

//validation ok
app.register(fastifyBasicAuth, {
validate: async function validatePromise (username, password, req, reply) {
expectType<string>(username)
Expand All @@ -23,6 +24,21 @@ app.register(fastifyBasicAuth, {
header: 'x-forwarded-authorization'
})

//validation failure
app.register(fastifyBasicAuth, {
validate: async function validatePromise (username, password, req, reply) {
expectType<string>(username)
expectType<string>(password)
expectType<FastifyRequest>(req)
expectType<FastifyReply>(reply)
expectType<FastifyInstance>(this)
return new Error("unauthorized")
},
header: 'x-forwarded-authorization'
})



app.register(fastifyBasicAuth, {
validate: function validateCallback (username, password, req, reply, done) {
expectType<string>(username)
Expand Down