add kiss packages count #2072
add kiss packages count #2072
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for counting KISS Linux packages in the fastfetch package detection module. KISS Linux is a Linux distribution that uses a simple package manager, and while the mainline project is no longer actively maintained, it continues to be supported by the community at kisscommunity.org.
Key Changes
- Added KISS package manager detection using the
/var/db/kiss/installeddirectory - Integrated KISS package counting across all relevant code paths (printing, formatting, JSON output, and configuration)
- Added flag bit for enabling/disabling KISS package detection
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/detection/packages/packages.h | Added kiss field to FFPackagesResult struct for storing package count |
| src/modules/packages/option.h | Added FF_PACKAGES_FLAG_KISS_BIT flag using bit 31 for KISS package detection control |
| src/detection/packages/packages_linux.c | Implemented KISS package counting by checking /var/db/kiss/installed directory |
| src/modules/packages/packages.c | Integrated KISS in print output, format arguments, JSON config/result generation, and module info |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
LGTM. Off topic. The ksh version detection seems broken. Does |
No, OpenBSD's OKSH doesn't use this way to show version, but it can show version by output variable $KSH_VERSION |
2 participants
Sorry to bother you, but this PR adds the kiss packages count support.
I knew the mainline of kiss linux and kiss package manager is dead. but it is still maintaining by unofficial community: https://kisscommunity.org/ , so I don't think it should be abandoned.
I promise I have tested this on my machine, its works fine.
I can't programming well, so I'm not sure if it can be used, I'm so sorry.