fix(detection/terminalshell): use absolute path to shell if available

[jnooree]

Sometimes shell executable name (exe; e.g., zsh) might resolve to a different path than path to the login shell (exePath; e.g., /bin/zsh). This PR tries to use absolute path to the login shell if possible, and fallback to previous behavior if absolute path is not available.

[CarterLi]

Do the same for terminals?

[CarterLi]

Do the same for terminals?

[jnooree]

Do the same for terminals?

Yes, if you could give me the code location, I can try fixing that too.

[CarterLi]

Well, you know the file you modified is called terminalshell.c

[jnooree]

Oh it's in the same file. Wait for me...

[jnooree]

e914504 fixes terminal.

[Copilot]

Pull request overview

This PR modifies the terminal and shell detection logic to prefer absolute paths (exePath) over executable names (exe) when available. The change ensures that the correct shell binary is used for version detection, avoiding cases where the executable name might resolve to a different location than the actual login shell.

Key Changes

• Refactored shell version detection functions to accept only the executable path parameter, removing the separate exePath parameter
• Added logic to select exePath over exe when exePath is available before calling version detection functions
• Applied consistent handling across both Windows and Linux platforms

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
terminalshell_windows.c	Selects exePath over exe when available before calling fftsGetTerminalVersion
terminalshell_linux.c	Selects exePath over exe when available before calling fftsGetTerminalVersion
terminalshell.c	Refactored getShellVersionBash and getShellVersionZsh to remove exePath parameter and added path selection logic in fftsGetShellVersion

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.