DevTools: Fix nested HOC name extraction in extractHOCNames #35398
+34
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
extractHOCNamesis responsible for unwrapping displayName strings such as: withFoo(withBar(Component))The previous implementation used a global RegExp and iterated via RegExp.exec() while mutating the input string on each unwrap. Because global RegExp instances carry state via
lastIndex, nested wrappers could stop unwrapping early and only record the outermost HOC.Solution
Switch to an anchored, non-global RegExp so each unwrap re-parses the updated string from the beginning, eliminating
lastIndexdrift across iterations.Tests
Test Plan
node ./scripts/jest/jest-cli.js --project devtools --build
--runTestsByPath packages/react-devtools-shared/src/tests/extractHOCNames-test.js