Skip to content

Conversation

@TerryTaoYY
Copy link

@TerryTaoYY TerryTaoYY commented Dec 21, 2025

Problem

extractHOCNames is responsible for unwrapping displayName strings such as: withFoo(withBar(Component))

The previous implementation used a global RegExp and iterated via RegExp.exec() while mutating the input string on each unwrap. Because global RegExp instances carry state via lastIndex, nested wrappers could stop unwrapping early and only record the outermost HOC.

Solution

Switch to an anchored, non-global RegExp so each unwrap re-parses the updated string from the beginning, eliminating lastIndex drift across iterations.

Tests

  • Added unit coverage for:
    • nested wrappers
    • a single wrapper
    • no HOC wrappers

Test Plan

node ./scripts/jest/jest-cli.js --project devtools --build
--runTestsByPath packages/react-devtools-shared/src/tests/extractHOCNames-test.js

extractHOCNames unwraps displayName strings like: withFoo(withBar(Component))

The previous implementation used a global RegExp and relied on RegExp.exec() while mutating the input string. Because global RegExp instances keep state via lastIndex, nested wrappers could stop unwrapping early and only record the outermost wrapper.

Use an anchored, non-global RegExp so each unwrap re-parses the updated name from the beginning, avoiding lastIndex drift.

Add unit tests covering nested wrappers, a single wrapper, and no-wrapper cases.

Test Plan:
node ./scripts/jest/jest-cli.js --project devtools --build \
  --runTestsByPath packages/react-devtools-shared/src/__tests__/extractHOCNames-test.js
@meta-cla
Copy link

meta-cla bot commented Dec 21, 2025

Hi @TerryTaoYY!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Dec 21, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant