Rename token transfer cookies to Etherpad-specific names to avoid conflicts #7277
+25
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fer/:token endpoint to epToken and epPrefsHttp. Avoid collisions with common application cookies such as sessionID or token that are frequently used by external frameworks running on the same parent domain. Keep the cookie semantics (path /, one-year maxAge) and payload unchanged so existing integrations can migrate by simply reading the new, Etherpad-specific cookie names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the cookies set by the /tokenTransfer/:token endpoint to use Etherpad‑specific names:
token → epToken
prefsHttp → epPrefsHttp
Using generic cookie names like token can easily collide with existing session or auth cookies used by apps that embed Etherpad under the same parent domain (for example, sessionID, token, etc.). Renaming these cookies to Etherpad‑specific names improves interoperability and avoids unexpected overwrites while keeping the current behavior intact.
Implementation details:
The persistence format in the database (tokenTransfer:) and the response payload remain unchanged.
Cookie options (path: "/" and one‑year maxAge) are preserved so existing clients can migrate by simply reading the new cookie names.
The change is limited to the token transfer Express hook and does not modify any other cookies or session logic.