fix(m5stack-tab5): Fix component manifest and clean up cmakelists #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the component manifest file for the M5Stack Tab5 BSP component by adding comprehensive metadata and reorganizes dependencies alphabetically in both the manifest and CMakeLists.txt files.
Key Changes:
- Added metadata fields including license, maintainers, documentation, examples, and tags to the component manifest
- Removed commented-out dependency entries (ble_gatt_server and wifi)
- Alphabetized dependencies in both idf_component.yml and CMakeLists.txt
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/m5stack-tab5/idf_component.yml | Added metadata fields (license, maintainers, documentation, examples, tags), removed commented dependencies, and reorganized dependencies alphabetically |
| components/m5stack-tab5/CMakeLists.txt | Alphabetized the list of required components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.