Skip to content

Conversation

@finger563
Copy link
Contributor

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Hardware

  • I have updated the design files (schematic, board, libraries).
  • I have attached the PDFs of the SCH / BRD to this PR
  • I have updated the design output (GERBER, BOM) files.

Copilot AI review requested due to automatic review settings October 28, 2025 15:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances audio testing across three hardware components by improving how audio files are loaded and configured. The changes enable dynamic sample rate extraction from WAV file headers and proper audio subsystem configuration.

Key changes:

  • Modified load_audio() to return success status and extract sample rate from WAV headers via output parameters
  • Added WAV header parsing to extract sample rate (bytes 24-27) and strip the 44-byte header from audio data
  • Updated call sites to handle the new return signature and configure audio sample rate accordingly

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
components/t-deck/example/main/t_deck_example.cpp Updated audio loading to parse WAV headers and configure sample rate for t-deck component
components/m5stack-tab5/example/main/m5stack_tab5_example.cpp Updated audio loading to parse WAV headers and configure sample rate for m5stack-tab5 component
components/esp-box/example/main/esp_box_example.cpp Updated audio loading to parse WAV headers and configure sample rate for esp-box component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit c7d38ed into main Oct 28, 2025
98 of 100 checks passed
@finger563 finger563 deleted the feat/better-audio-test branch October 28, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants