Skip to content

Conversation

@aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Nov 5, 2025

Prerequisites checklist

What is the purpose of this pull request?

This change removes the custom semantic prefix preset to align with release-please's expected commit conventions:

  • dependencies updates now use "fix:" prefix
  • devDependencies updates now use "chore:" prefix

The removal enables better integration with release-please by using standard semantic commit prefixes that release-please recognizes for automatic version bumping and changelog generation.

Especially after the @eslint/* update, using "fix", release-please can update the version (whereas using "chore" cannot).

What changes did you make? (Give an overview)

Related Issues

refs:eslint/markdown#577 (comment)

Is there anything you'd like reviewers to focus on?

This change removes the custom semantic prefix preset to align with release-please's expected commit conventions:
- dependencies updates now use "fix:" prefix
- devDependencies updates now use "chore:" prefix

The removal enables better integration with release-please by using standard semantic commit prefixes that release-please recognizes for automatic version bumping and changelog generation.
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Nov 5, 2025
@eslintbot eslintbot added this to Triage Nov 5, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 5, 2025
@aladdin-add aladdin-add moved this from Needs Triage to Evaluating in Triage Nov 5, 2025
@lumirlumir
Copy link
Member

Hi, @aladdin-add

Would there be any progress on this PR, or is something blocking it?

@aladdin-add aladdin-add self-assigned this Nov 23, 2025
@aladdin-add
Copy link
Member Author

No worries, it's still on my radar. I just need to run some tests on it, and I'll get back to you soon.

@aladdin-add
Copy link
Member Author

it's working as expected:
image

@aladdin-add aladdin-add marked this pull request as ready for review December 8, 2025 08:22
Copilot AI review requested due to automatic review settings December 8, 2025 08:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the ignorePresets configuration from Renovate's base configuration to enable standard semantic commit prefixes for dependency updates. By no longer ignoring the :semanticPrefixFixDepsChoreOthers preset, Renovate will now use "fix:" for dependencies and "chore:" for devDependencies, allowing release-please to properly recognize these commits for automatic version bumping and changelog generation.

Key Changes:

  • Removed ignorePresets: [":semanticPrefixFixDepsChoreOthers"] from base Renovate configuration to enable default semantic commit prefixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aladdin-add aladdin-add moved this from Evaluating to Implementing in Triage Dec 8, 2025
@lumirlumir lumirlumir moved this from Implementing to Triaging in Triage Dec 8, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share the URL of the forked testing repository so I can double-check?

@aladdin-add
Copy link
Member Author

https://github.com/aladdin-add/eslint-css. however, it has been updated to testing #39. 😂

To test it, it's also needed to update the branch in eslint-base.json: 3a58e30, as renovate will use the default branch by default.

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the origin of the ignorePresets: [":semanticPrefixFixDepsChoreOthers"], setting in the eslint repository, it appears to come from the initial template, so there doesn't seem to be any specific intention behind adding this line. (Or maybe I'm missing something, since the discussion thread for that PR is quite long.)

Related PR: eslint/eslint#17567

So, the upside of this change is as follows:

  • @eslint/* dependencies often come with direct (closely related) side effects such as bug fixes or new features, so using the fix prefix for those makes sense to me.

However, my concerns about this change are:

  • According to the Renovate documentation, this option appears to apply to all direct dependencies. Because of that, I think it might make more sense to restrict the fix prefix only to ESLint-related dependencies. In some cases, other downstream dependency updates don’t actually affect our codebase.

Reference: Renovate Docs — https://docs.renovatebot.com/presets-default/#semanticprefixfixdepschoreothers


To summarize, my opinion is to restrict the fix prefix only to ESLint-related dependencies (not devDependencies).

But, I’d also like to gather more input from the team about using fix prefix for dependencies updates in general. @eslint/eslint-team

@lumirlumir lumirlumir moved this from Triaging to Feedback Needed in Triage Dec 10, 2025
@lumirlumir lumirlumir requested a review from nzakas December 10, 2025 11:04
@aladdin-add
Copy link
Member Author

aladdin-add commented Dec 10, 2025

In most cases, security updates are released as patch versions. Therefore, using fix is helpful for these situations (third‑party packages) as well, not just for ESLint’s own packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Feedback Needed

Development

Successfully merging this pull request may close these issues.

3 participants