-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix: Remove ignorePresets from Renovate configuration #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change removes the custom semantic prefix preset to align with release-please's expected commit conventions: - dependencies updates now use "fix:" prefix - devDependencies updates now use "chore:" prefix The removal enables better integration with release-please by using standard semantic commit prefixes that release-please recognizes for automatic version bumping and changelog generation.
|
Hi, @aladdin-add Would there be any progress on this PR, or is something blocking it? |
|
No worries, it's still on my radar. I just need to run some tests on it, and I'll get back to you soon. |
ae3f586 to
74b39ee
Compare
3a58e30 to
74b39ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the ignorePresets configuration from Renovate's base configuration to enable standard semantic commit prefixes for dependency updates. By no longer ignoring the :semanticPrefixFixDepsChoreOthers preset, Renovate will now use "fix:" for dependencies and "chore:" for devDependencies, allowing release-please to properly recognize these commits for automatic version bumping and changelog generation.
Key Changes:
- Removed
ignorePresets: [":semanticPrefixFixDepsChoreOthers"]from base Renovate configuration to enable default semantic commit prefixes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lumirlumir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please share the URL of the forked testing repository so I can double-check?
|
https://github.com/aladdin-add/eslint-css. however, it has been updated to testing #39. 😂 To test it, it's also needed to update the branch in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the origin of the ignorePresets: [":semanticPrefixFixDepsChoreOthers"], setting in the eslint repository, it appears to come from the initial template, so there doesn't seem to be any specific intention behind adding this line. (Or maybe I'm missing something, since the discussion thread for that PR is quite long.)
Related PR: eslint/eslint#17567
So, the upside of this change is as follows:
@eslint/*dependencies often come with direct (closely related) side effects such as bug fixes or new features, so using thefixprefix for those makes sense to me.
However, my concerns about this change are:
- According to the Renovate documentation, this option appears to apply to all direct
dependencies. Because of that, I think it might make more sense to restrict thefixprefix only to ESLint-related dependencies. In some cases, other downstream dependency updates don’t actually affect our codebase.
Reference: Renovate Docs — https://docs.renovatebot.com/presets-default/#semanticprefixfixdepschoreothers
To summarize, my opinion is to restrict the fix prefix only to ESLint-related dependencies (not devDependencies).
But, I’d also like to gather more input from the team about using fix prefix for dependencies updates in general. @eslint/eslint-team
|
In most cases, security updates are released as patch versions. Therefore, using fix is helpful for these situations (third‑party packages) as well, not just for ESLint’s own packages. |

Prerequisites checklist
What is the purpose of this pull request?
This change removes the custom semantic prefix preset to align with release-please's expected commit conventions:
The removal enables better integration with release-please by using standard semantic commit prefixes that release-please recognizes for automatic version bumping and changelog generation.
Especially after the @eslint/* update, using "fix", release-please can update the version (whereas using "chore" cannot).
What changes did you make? (Give an overview)
Related Issues
refs:eslint/markdown#577 (comment)
Is there anything you'd like reviewers to focus on?