176 mappers should never return null #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add protobuf-java-util dependency to the pom.xml, required by the new unit-test add a unit-test to make sure an hypothesis is true
The mapper are not allowed to return null anymore. It is the responsibility of the application to perform domain value check and defaultToNull post processing when appropriate.
… null replace one unit-test to conform with the new implementation that ban null
Contributor
|
@zartc Sorry for the late response, I agree with your reasoning. On the proto->domain side I would like to see 2 different implementations, yours (map to empty domain) as well as the existing one (map to null). If we split the existing mapper class into 3 variants
the developer can select the appropriate implementation based on his/her needs. It also avoid breaking (runtime) any existing use of this library (mapper |
|
Any news? |
Contributor
|
This has unfortunately gone unnoticed. The handling for mapping TO protobuf has been included in #498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the code that implements the ban of null return values from mappers.
The changes consist of systematically return a "default' value: empty string or arrays, EPOCH, zero, or protobuff's getDefaultInstance.
Close #176