Skip to content

fix: Remove ember-responsive #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged

fix: Remove ember-responsive #1676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions addon/components/docs-viewer/x-nav/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,26 @@
{{#if this.media.isMobile}}
<div class="docs-text-right docs-px-4 md:docs-px-6 docs-mt-4">
<button {{on "click" (toggle "isShowingMenu" this)}}
class="docs-text-grey-darkest docs-py-2 docs-text-xs docs-rounded docs-uppercase docs-font-medium">
☰ Menu
</button>
</div>
{{/if}}
<div class="docs-block md:docs-hidden docs-text-right docs-px-4 md:docs-px-6 docs-mt-4">
<button {{on "click" (toggle "isShowingMenu" this)}}
class="docs-text-grey-darkest docs-py-2 docs-text-xs docs-rounded docs-uppercase docs-font-medium">
☰ Menu
</button>
</div>

<div class="AddonDocs-DocsViewer-Nav docs-bg-grey-lightest docs-border-r docs-flex-no-shrink" ...attributes>
<nav {{on "click" (set this "isShowingMenu" false)}}
class="
docs-absolute docs-right-0 docs-shadow-lg md:docs-shadow-none docs-mr-2 md:docs-mr-0 md:docs-pl-2
docs-max-w-xs docs-w-90% md:docs-w-72 docs-z-10 docs-transition md:docs-sticky md:docs-top-0
{{if this.media.isMobile
(if this.isShowingMenu "docs-opacity-100 docs-bg-white" "docs-opacity-0 docs-pointer-events-none")
}}
{{if this.isShowingMenu "docs-opacity-100 docs-bg-white md:docs-opacity-0" "docs-opacity-0 md:docs-opacity-100 docs-pointer-events-none md:docs-pointer-events-auto"}}
Copy link
Contributor Author

@MichalBryxi MichalBryxi May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the truthy part of this can be ommited as it won't be shown anyways as the button toggling isShowingMenu won't be there. But for a good measure I added the opacity styles anyway.

">
<div class="docs-pt-px docs-mb-8 docs-px-3 md:docs-px-4 md:docs-max-h-screen md:docs-overflow-y-scroll">
{{#if this.media.isMobile}}
<div class="absolute top-0 docs-text-right right-4">
<button
class="docs-text-grey-darkest docs-opacity-50 hover:docs-opacity-100 docs-text-large-5 docs-py-2 docs-no-underline"
{{on "click" (set this "isShowingMenu" false)}}
>
&times;
</button>
</div>
{{/if}}
<div class="docs-block md:docs-hidden absolute top-0 docs-text-right right-4">
<button
class="docs-text-grey-darkest docs-opacity-50 hover:docs-opacity-100 docs-text-large-5 docs-py-2 docs-no-underline"
{{on "click" (set this "isShowingMenu" false)}}
>
&times;
</button>
</div>

<DocsViewer::XNavList>
{{yield (hash
Expand Down
1 change: 0 additions & 1 deletion addon/components/docs-viewer/x-nav/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export default class XNav extends Component {
root;

@service store;
@service media;

@tracked isShowingMenu;

Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"ember-concurrency": "^3.1.1",
"ember-keyboard": "^9.0.1",
"ember-modal-dialog": "^4.1.4",
"ember-responsive": "^5.0.0",
"ember-router-generator": "^2.0.0",
"ember-router-scroll": "^4.1.2",
"ember-set-helper": "^2.0.1",
Expand Down
Loading