Fix port zero when tranceiver stopping #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 87.86% 87.77% -0.10%
==========================================
Files 54 54
Lines 2752 2756 +4
==========================================
+ Hits 2418 2419 +1
- Misses 334 337 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
roznawsk
commented
Jul 28, 2025
| # https://www.w3.org/TR/webrtc/#dfn-check-if-negotiation-is-needed | ||
| defp tr_negotiation_needed?([], _), do: false | ||
|
|
||
| defp tr_negotiation_needed?([tr | _transceivers], _state) when tr.stopping and not tr.stopped, |
Contributor
There was a problem hiding this comment.
Can we add a comment referencing this section?
Member
Author
There was a problem hiding this comment.
It's right above already, so I think we're good
mickel8
approved these changes
Jul 29, 2025
| # https://www.w3.org/TR/webrtc/#dfn-check-if-negotiation-is-needed | ||
| defp tr_negotiation_needed?([], _), do: false | ||
|
|
||
| defp tr_negotiation_needed?([tr | _transceivers], _state) when tr.stopping and not tr.stopped, |
Contributor
There was a problem hiding this comment.
Can we add a comment referencing this section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here: https://www.w3.org/TR/webrtc/#methods-8
The zero port shouldn't be generated in the answer, if the transceiver is in the
stoppingstate.