Skip to content

Reset stmt when done #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Reset stmt when done #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions c_src/sqlite3_nif.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,7 @@ exqlite_multi_step(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
return am_busy;

case SQLITE_DONE:
sqlite3_reset(statement->statement);
return enif_make_tuple2(env, am_done, rows);

case SQLITE_ROW:
Expand Down Expand Up @@ -683,10 +684,13 @@ exqlite_step(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
am_row,
make_row(env, statement->statement));
case SQLITE_BUSY:
sqlite3_reset(statement->statement);
return am_busy;
case SQLITE_DONE:
sqlite3_reset(statement->statement);
return am_done;
default:
sqlite3_reset(statement->statement);
return make_sqlite3_error_tuple(env, rc, conn->db);
}
}
Expand Down
1 change: 0 additions & 1 deletion lib/exqlite/sqlite3.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ defmodule Exqlite.Sqlite3 do
args_count = length(args)

if args_count == params_count do
reset(stmt)
bind_all(args, stmt, 1)
else
raise ArgumentError, "expected #{params_count} arguments, got #{args_count}"
Expand Down
Loading