refactor: improve Nx.Defn.Evaluator debugging usability #1644
+421
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omparison between nodes (see save_as documentation). Created a backend_comparison.livemd file to document comparison between backends for the evaluator. Added the backend_comparison and complex_fft to the mix.exs file
polvalente
reviewed
Nov 14, 2025
polvalente
reviewed
Nov 14, 2025
polvalente
reviewed
Nov 14, 2025
polvalente
reviewed
Nov 14, 2025
| * **Arguments** - List containing parameters and tensors as strings | ||
| * **Result** - Executable code that reconstructs the output tensor from binary | ||
|
|
||
| ## Verifying Executability |
Contributor
There was a problem hiding this comment.
Instead of a separate section, I think this could just be a ### header on the Examining the Output Files section
polvalente
reviewed
Nov 14, 2025
polvalente
reviewed
Nov 14, 2025
polvalente
reviewed
Nov 14, 2025
…tput Files' and the code now just uses
Chapaman
commented
Nov 14, 2025
Contributor
Author
Chapaman
left a comment
Chapaman
left a comment
There was a problem hiding this comment.
Now the Verifying Executability section is within Examining the Output Files and the code now just uses Code.eval_file()
polvalente
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
evaluator.exto produce.exsfiles that can be executed for comparison between nodes (see save_as documentation).Creates a
backend_comparison.livemdfile to document comparison between backends for the evaluator.Adds the
backend_comparisonandcomplex_fftto themix.exsfile