Skip to content

fix: Nx.Defn.Expr will now promote constants based on the surrounding non-constant tensors for binary operations #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: Nx.Defn.Expr will now promote constants based on the surrounding non-constant tensors for binary operations #1570

merged 1 commit into from
Jan 23, 2025

Conversation

@polvalente
Copy link
Contributor

@polvalente polvalente commented Jan 16, 2025 •
edited
Loading

closes #1567

@polvalente polvalente self-assigned this Jan 16, 2025
@polvalente polvalente requested a review from josevalim January 16, 2025 19:38
@polvalente polvalente merged commit b01e94a into main Jan 23, 2025
8 checks passed
@polvalente polvalente deleted the pv-fix/constants-type-inference branch January 23, 2025 16:37
@polvalente polvalente mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josevalim josevalim josevalim approved these changes

Assignees

@polvalente polvalente

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Single vs. double precision issue

3 participants

@polvalente @josevalim