Migrate the Elasticsearch script resource to the terraform-plugin-framework and remove legacy SDKv2 implementation #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate the Elasticsearch script resource to the terraform-plugin-framework
Migrate the Elasticsearch script resource to the terraform-plugin-framework
Sep 11, 2025
Copilot finished work on behalf of
tobio
September 11, 2025 10:04
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ework diagnostics Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
Copilot finished work on behalf of
tobio
September 11, 2025 10:42
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ramework diagnostics and move read function to read.go Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
Copilot finished work on behalf of
tobio
September 11, 2025 11:15
Member
|
cla/check |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…quested in review Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
Copilot
AI
changed the title
Migrate the Elasticsearch script resource to the terraform-plugin-framework
Migrate the Elasticsearch script resource to the terraform-plugin-framework and remove legacy SDKv2 implementation
Sep 14, 2025
Copilot finished work on behalf of
tobio
September 14, 2025 09:57
tobio
approved these changes
Sep 15, 2025
wandergeek
previously approved these changes
Sep 23, 2025
* origin/main: fix: nil reference in api.kibana_synthetics.go:418 in case of unmarshable arrays (#1320) Bump github.com/hashicorp/terraform-plugin-framework (#1326) Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.37.0 to 2.38.0 (#1325) chore(deps): update golang:1.25.1 docker digest to 8305f5f (#1322) Clarify how acceptance tests should be run (#1324) Move diag utilities from utils to dedicated diagutil package (#1317) Add support for Kafka Fleet output types. (#1302) Allow a default for `allow_restricted_indices` within an API Key role descriptor (#1315) Improve docs generation (#1313) Add optional preventInitialBackfill for SLO API (#1071) Add support for dataViewId (#1305) [Feature] Add unenrollment_timeout parameter to Fleet Agent Policy resource (#1306) chore(deps): update actions/setup-go action to v6 (#1301) chore(deps): update golang docker tag to v1.25.1 (#1300) Update generated SLO client. (#1303)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Changes
Complete migration to Plugin Framework with full removal of legacy SDKv2 code:
Removed SDK wrapper functions: Deleted
GetScriptSDK,PutScriptSDK, andDeleteScriptSDKfunctions frominternal/clients/elasticsearch/cluster.goas they are no longer needed.Removed legacy SDKv2 resource: Completely removed
internal/elasticsearch/cluster/script.gowhich contained the old SDKv2 script resource implementation.Maintained Plugin Framework resource: The new script resource in
internal/elasticsearch/cluster/script/remains fully functional and properly registered in the Plugin Framework provider.The migration is now complete with no legacy SDKv2 code remaining. All tests pass and the resource works correctly with the Plugin Framework.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.