Skip to content

Conversation

@alex-spies
Copy link
Contributor

@alex-spies alex-spies commented Dec 9, 2025

#137432 added a minimum transport version to data types that are under construction, so that even in SNAPSHOT builds a coordinator node can decide whether other nodes or clusters are new enough to understand a data type that recently became supported in ESQL.

The EXPONENTIAL_HISTOGRAM type is one such type that is currently under construction. #137432 wrongly gave it a minimum transport version that was also backported to 9.2, even though the type is exclusive to 9.3 so far (even in SNAPSHOT builds).

To keep things consistent, use a newer minimum transport version for EXPONENTIAL_HISTOGRAM, namely the first version after it was added which was also not backported to 9.2.

(There wasn't any breakage from this because we don't have tests that do anything with EXPONENTIAL_HISTOGRAM in mixed 9.2/9.3 clusters/CCS to my knowledge.)

@alex-spies alex-spies requested a review from JonasKunz December 9, 2025 12:19
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@JonasKunz
Copy link
Contributor

JonasKunz commented Dec 9, 2025

There wasn't any breakage from this because we don't have tests that do anything with EXPONENTIAL_HISTOGRAM in mixed 9.2/9.3 clusters/CCS to my knowledge.

Correct. exponential_histograms participate in mixed cluster tests via the CSV tests, but those are guarded by a capability which has been renamed with every change. So effectively they only run on homogenous, latest clusters.

@alex-spies alex-spies added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 9, 2025
@elasticsearchmachine elasticsearchmachine merged commit 489dc0c into elastic:main Dec 9, 2025
34 checks passed
@alex-spies alex-spies deleted the use_better_tv_for_exp_histo branch December 9, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants