Skip to content

Conversation

@kderusso
Copy link
Member

@kderusso kderusso commented Dec 5, 2025

Simplifies docs example for ES|QL CHUNK function and allows CSV tests to run chunking tests.

@kderusso kderusso added >docs General docs changes :Search Relevance/ES|QL Search functionality in ES|QL labels Dec 8, 2025
@kderusso kderusso changed the title Re-enable CSV tests for CHUNK function ES|QL: Simplify CHUNK examples and enable CSV tests Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🔍 Preview links for changed docs

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@kderusso kderusso marked this pull request as ready for review December 8, 2025 21:23
@kderusso kderusso requested a review from ioanatia December 8, 2025 21:23
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Dec 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

| KEEP book_no, title, chunks
| SORT book_no
// tag::chunk-example[]
ROW result = CHUNK("It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief.", {"strategy": "word", "max_chunk_size": 10, "overlap": 1})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't throw tomatoes at me, but this still could look better 🙈 - the way we render multi valued strings in the docs could be improved, because looking at the results, it's not super obvious we return multiple values:

Screenshot 2025-12-09 at 11 12 16
ROW result = CHUNK("It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief.", {"strategy": "word", "max_chunk_size": 10, "overlap": 1})
| MV_EXPAND result

just a suggestion, feel free to also merge it as it is.

@kderusso kderusso enabled auto-merge (squash) December 9, 2025 13:41
@kderusso kderusso merged commit 86f6eb0 into elastic:main Dec 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search Relevance/ES|QL Search functionality in ES|QL Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants