-
Notifications
You must be signed in to change notification settings - Fork 25.7k
ES|QL: Simplify CHUNK examples and enable CSV tests #139159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES|QL: Simplify CHUNK examples and enable CSV tests #139159
Conversation
🔍 Preview links for changed docs |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/core-docs (Team:Docs) |
| | KEEP book_no, title, chunks | ||
| | SORT book_no | ||
| // tag::chunk-example[] | ||
| ROW result = CHUNK("It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief.", {"strategy": "word", "max_chunk_size": 10, "overlap": 1}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't throw tomatoes at me, but this still could look better 🙈 - the way we render multi valued strings in the docs could be improved, because looking at the results, it's not super obvious we return multiple values:
ROW result = CHUNK("It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief.", {"strategy": "word", "max_chunk_size": 10, "overlap": 1})
| MV_EXPAND result
just a suggestion, feel free to also merge it as it is.
Simplifies docs example for ES|QL
CHUNKfunction and allows CSV tests to run chunking tests.