Remove exponential_histogram feature flag #138968

JonasKunz · 2025-12-03T11:15:02Z

Removes the feature flag for the exponential_histogram field mapper and ES|QL type.

… into exp-histo-remove-featureflag # Conflicts: # server/src/main/resources/transport/upper_bounds/9.3.csv

…tureflag

…tureflag # Conflicts: # server/src/main/resources/transport/upper_bounds/9.3.csv # x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/plugin/EsqlCorePlugin.java # x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java # x-pack/plugin/esql/qa/server/multi-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/MultiClusterSpecIT.java # x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/EsqlSpecIT.java # x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java # x-pack/plugin/esql/qa/testFixtures/src/main/resources/exponential_histogram.csv-spec # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/TestCaseSupplier.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/AbstractLogicalPlanOptimizerTests.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LogicalPlanOptimizerTests.java

elasticsearchmachine · 2025-12-05T10:51:11Z

Pinging @elastic/es-analytical-engine (Team:Analytics)

elasticsearchmachine · 2025-12-05T10:51:11Z

Pinging @elastic/es-storage-engine (Team:StorageEngine)

docs/reference/query-languages/esql/kibana/definition/functions/max_over_time.json

...rc/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/CountErrorTests.java

...c/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/ValuesErrorTests.java

kkrik-es

Please wait for Nik too. You also need to update (separately):

https://www.elastic.co/docs/reference/query-languages/esql/limitations#_supported_types

gmarouli · 2025-12-09T12:32:11Z

...ics/src/test/java/org/elasticsearch/xpack/analytics/mapper/TDigestFieldBlockLoaderTests.java

    @Before
    public void setup() {
-        assumeTrue("Only when exponential_histogram feature flag is enabled", TDigestFieldMapper.TDIGEST_FIELD_MAPPER.isEnabled());
+        assumeTrue("Only when tdigest_field_mapper feature flag is enabled", TDigestFieldMapper.TDIGEST_FIELD_MAPPER.isEnabled());


I think this was a type but it might be confusing now with this change, so I updated it.

Yeah looks like a copy-paste error, thanks for fixing!

nik9000

Looks good to me.

Would you kindly, in a follow up, have a look at improving assertNumberOfCheckedSignatures some? I'd left it too prone to magic when I first wrote it. Sending the count and a limited list to the method would make it much less magic. In all of the cases we override this and assert the count we're looking for a count much less than, say, 50. Then we'd have the whole list to work with and it'd be easy to mark each unsupported signature as expected in some way.

nik9000 · 2025-12-09T13:21:48Z

...qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/AllSupportedFieldsTestCase.java

     * Is the type supported in indices?
     */
-    private static boolean supportedInIndex(DataType t) {
+    private static boolean supportedInIndex(DataType t, TransportVersion minimumVersion) {


...rc/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/CountErrorTests.java

…tureflag # Conflicts: # docs/reference/query-languages/esql/_snippets/functions/types/absent_over_time.md # docs/reference/query-languages/esql/_snippets/functions/types/present_over_time.md # server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java # server/src/main/resources/transport/upper_bounds/9.3.csv

alex-spies

The changes to DataType and AllSupportedFieldsTestCase look good to me!

alex-spies · 2025-12-09T15:19:06Z

...qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/AllSupportedFieldsTestCase.java

            // Enrich policies don't work with types that have mandatory fields in the mapping.
            // https://github.com/elastic/elasticsearch/issues/127350
-            case AGGREGATE_METRIC_DOUBLE, SCALED_FLOAT,
+            case AGGREGATE_METRIC_DOUBLE, SCALED_FLOAT, EXPONENTIAL_HISTOGRAM,


Is there a separate issue for ENRICH support for exponential_histogram that we could/should link here, or does #127350 extend to exponential_histogram?

There is no technical limitation on supporting exponential_histogram in ENRICH IINM, we just haven't implemented it yet.

I've created an issue to track this alongside with other language limitations this type currently has:
#139255

…tureflag # Conflicts: # x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java

JonasKunz added 18 commits December 2, 2025 10:36

Remove mapper feature flag

645f23f

Add test node feature and make yaml tests depend on it

8635eed

Move yaml tests to general XPack tests folder

b42afbd

Add transport version for exponential_histogram esql type

a71a6bb

ESQL: Implement TO_STRING for exponential_histogram

5af240f

Merge branch 'main' into esql-exponential-histo-tostring

458af68

Fix ESQL tests, update function type checks and declarations

a8988c6

fix analyzer test

12323a7

Add toString CSV test

cc92144

Upgrade capability

aa4818a

checkstyle

51b61af

Merge branch 'main' into esql-exponential-histo-tostring

bd7aaca

simplify ConverterEvaluatorImplementer

f7991e4

Merge remote-tracking branch 'origin/esql-exponential-histo-tostring'…

054ef13

… into exp-histo-remove-featureflag # Conflicts: # server/src/main/resources/transport/upper_bounds/9.3.csv

Update transport version

2a1b69e

Remove ESQL expo histo feature flag

8edf735

Renamed capability

35905a2

spotless

c23e5f2

elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.3.0 labels Dec 3, 2025

JonasKunz added 8 commits December 3, 2025 13:03

Attempt to add exponential_histogram to AllSupportedFieldsTestCase

4c5a1b1

Merge branch 'main' into exp-histo-remove-featureflag

bba2b18

checkstyle

3559017

Fix AllSupportedFieldsTestCase

b317c70

Merge remote-tracking branch 'elastic/main' into exp-histo-remove-fea…

63a5ab5

…tureflag

Remove unnecessary capability checks

06e41e2

Add to case tests

24782af

JonasKunz force-pushed the exp-histo-remove-featureflag branch from 3e9b408 to 24782af Compare December 5, 2025 06:23

Update transport versions

9d41555

JonasKunz added :StorageEngine/Mapping The storage related side of mappings :Analytics/ES|QL AKA ESQL >non-issue labels Dec 5, 2025

JonasKunz marked this pull request as ready for review December 5, 2025 10:50

elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine labels Dec 5, 2025

JonasKunz requested review from kkrik-es and nik9000 December 5, 2025 10:51

kkrik-es reviewed Dec 5, 2025

View reviewed changes

docs/reference/query-languages/esql/kibana/definition/functions/max_over_time.json Show resolved Hide resolved

kkrik-es reviewed Dec 5, 2025

View reviewed changes

...rc/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/CountErrorTests.java Outdated Show resolved Hide resolved

kkrik-es reviewed Dec 5, 2025

View reviewed changes

...c/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/ValuesErrorTests.java Outdated Show resolved Hide resolved

kkrik-es approved these changes Dec 5, 2025

View reviewed changes

Remove exponential histogram FF from downsampling

e88faa0

gmarouli reviewed Dec 9, 2025

View reviewed changes

github-actions bot deployed to docs-preview December 9, 2025 12:32 View deployment

JonasKunz mentioned this pull request Dec 9, 2025

Add option to generate exponential histogram fields to the OTLP intake #139119

Open

nik9000 approved these changes Dec 9, 2025

View reviewed changes

JonasKunz added 3 commits December 9, 2025 15:02

Fix transport versions

01fdd28

Add assert messages to assertNumberOfCheckedSignatures

9e2af85

github-actions bot deployed to docs-preview December 9, 2025 14:38 View deployment

alex-spies approved these changes Dec 9, 2025

View reviewed changes

JonasKunz added 3 commits December 9, 2025 16:56

Merge remote-tracking branch 'elastic/main' into exp-histo-remove-fea…

29f914a

…tureflag # Conflicts: # x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java

Link issue for enrich support

ec95da7

Merge branch 'main' into exp-histo-remove-featureflag

2868259

github-actions bot deployed to docs-preview December 9, 2025 16:00 View deployment

Fix sum_over_time.json

be2d05c

github-actions bot deployed to docs-preview December 9, 2025 17:11 View deployment

Remove exponential_histogram feature flag #138968

Are you sure you want to change the base?

Remove exponential_histogram feature flag #138968

Uh oh!

Conversation

JonasKunz commented Dec 3, 2025

Uh oh!

elasticsearchmachine commented Dec 5, 2025

Uh oh!

elasticsearchmachine commented Dec 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kkrik-es left a comment

Choose a reason for hiding this comment

Uh oh!

gmarouli Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

JonasKunz Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

nik9000 left a comment

Choose a reason for hiding this comment

Uh oh!

nik9000 Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alex-spies left a comment

Choose a reason for hiding this comment

Uh oh!

alex-spies Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

JonasKunz Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants