-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[ES|QL] Support CCS for inference commands #138522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @afoucret, I've created a changelog YAML for you. |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
ioanatia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look alright, but IMO it would be easier if we get the usage limits changes first.
this way we know there's always a LIMIT before the inference plans.
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add a new dataset, just use the existing dense_vector one.
| r.rerankFields(), | ||
| r.scoreAttribute() | ||
| ); | ||
| case Completion c -> new CompletionExec(c.source(), mappedChild, c.inferenceId(), c.prompt(), c.targetField()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we checked that there's no way to get to a place where we have an unexecutable plan?
IMO we should verify that there is a pipeline breaker before any of the inference plans.
92a6fe5 to
22f5c22
Compare
…dependency from text-embedding CSV tests.
ec2c0df to
b119cf6
Compare
|
Replaced by #139244 |
Closes #136860
This PR add CCS support for ES\QL query that are using an inference command (
RERANKandCOMPLETION) or an inference function (TEXT_EMBEDDING).The inference is always executed on the coordinator cluster, meaning that the endpoint need to exists on the coordinator clusters.