-
Notifications
You must be signed in to change notification settings - Fork 5
Compatibility fixes for new versions of PHPStan and Nette #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MartinMystikJonas zda sa ze toho dost vela popadalo v testoch. Budes to fixovat? |
|
Popadalo to v tagu {default}, protže Latte změnilo jak je implementovnaý a ta nová syntaxe je pro PHP stan neznámá |
|
Tests should be fixed once this is merged to PHPStan: phpstan/phpstan-src#3624 |
|
Ok keď sa to mergne do phpstanu, a prejdú nám testy, môžeš mergovat |
|
phpstan/phpstan-src#3624 has been merged and released in PHPStan 1.12.13/2.0.4. Can you try to rerun the tests to see if this PR can be merged? |
dd1f30d to
457a9f1
Compare
7e6c81c to
50c56ba
Compare
50c56ba to
8129cc6
Compare
|
@lulco Fixed. But Composer outdated complains because there is PHPStan 2.0. I think we can merge it and work on PHPStan2.0 compatibility later - I tried to update dependecies but there are some BC breaks and I am not sure how difficult it would be to fix. |
Agree, merge it and use it :) |
I made some fixes for compatibility with new PHPStan and Nette,
There is still one error remaining for variables with default values I cannot solve. I am not sure if it is our unintended Latte behaviour. I recall @dg planned some changes to how
{default}works.Variable with defaut value:
is now transformed to:
So variable type is resolved to
'default value'|nullinstead of'default value'as it was earlier.We shuld also bump minimal PHPStan version for compatibility with new release.