Skip to content

Conversation

@klaernie
Copy link
Member

This is a fairly simple change, but I think solves our problem from #419

@klaernie klaernie requested a review from theoludwig January 13, 2025 21:10
Copy link
Member

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it seems to resolve the issue, as the CI work first try.

However, I would not call this commit a "fix", as we don't need to create a release for it.

@theoludwig theoludwig changed the title fix: help the CI avoid ratelimits by authenticating ourselves, fixes #419 ci: avoid ratelimits by authenticating ourselves, fixes #419 Jan 14, 2025
@theoludwig theoludwig linked an issue Jan 14, 2025 that may be closed by this pull request
@klaernie
Copy link
Member Author

However, I would not call this commit a "fix", as we don't need to create a release for it.

Good point. I should put a cheat sheet with the conventional commit prefixes somewhere ;)

@theoludwig theoludwig changed the title ci: avoid ratelimits by authenticating ourselves, fixes #419 ci: avoid ratelimits by authenticating with GitHub Jan 15, 2025
@theoludwig theoludwig merged commit fc9a4ce into editorconfig-checker:master Jan 15, 2025
5 checks passed
@theoludwig
Copy link
Member

@klaernie Ah, it seems like, it was only luck, that the CI worked first try: https://github.com/editorconfig-checker/editorconfig-checker.javascript/actions/runs/12795906634/job/35674329171

😆

@github-actions
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Unreliable CI because of GitHub Rate Limiting

3 participants