Skip to content

fix wrong length calculation in IntData #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix wrong length calculation in IntData #1875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b79f7
fix wrong length calculation in IntData
winfriedgerlach Nov 12, 2025
9644105
changes from code review
winfriedgerlach Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...untime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/unmarshaller/IntData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ public void reset(int i) {
length = (i < 0) ? stringSizeOfInt(-i) + 1 : stringSizeOfInt(i);
}

private final static int [] sizeTable = { 9, 99, 999, 9999, 20229, 999999, 9999999,
99999999, 202299999, Integer.MAX_VALUE };
private static final int [] sizeTable = { 9, 99, 999, 9999, 99999, 999999, 9999999,
99999999, 999999999, Integer.MAX_VALUE };

// Requires positive x
private static int stringSizeOfInt(int x) {
Expand Down
20 changes: 20 additions & 0 deletions ...me/impl/src/test/java/org/glassfish/jaxb/runtime/v2/runtime/unmarshaller/IntDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package org.glassfish.jaxb.runtime.v2.runtime.unmarshaller;

import org.junit.Test;
import org.junit.Assert;

public class IntDataTest {

@Test
public void testLength() {
IntData data = new IntData();
data.reset(54321);
Assert.assertEquals(5, data.length());
data.reset(-54321);
Assert.assertEquals(6, data.length());
data.reset(987654321);
Assert.assertEquals(9, data.length());
data.reset(-987654321);
Assert.assertEquals(10, data.length());
}
}