Avoid TypeError: must be str, not bytes when the request fails #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Reopening #8 as a new PR as it was closed following moving around branches)
I have been seeing the following (non reproducible) error message from time to time with the fasta.py script:
The
restRequestfunction returns astrwhen the request succeeds. When the request fails, an additional call torequests.get(url)is performed, and the raw response.contentis returned asbytesinstead, without conversion.This PR converts the content to a
stralso in case of failure.PS: not sure if returning the error contents is the right thing to do in this context, but that's an other story.