Skip to content

Conversation

@aunyks
Copy link

@aunyks aunyks commented Oct 27, 2024

TL;DR

Notes for Reviewers

  • The formatting changes in vfs.js arise from running deno fmt against the file

@dyedgreen
Copy link
Owner

dyedgreen commented Nov 21, 2024

Hey, sorry for taking a while to get back to this!

This change looks great, outside of a few files that are flagged by the formatting in CI 👀

(Some of those have not changed in a while so they might have changed the formatting in Deno?)


```bash
deno bundle --import-map browser/import_map.json browser/mod.ts [output_bundle_path]
deno run --allow-run --allow-env --allow-read --allow-write ./browser/bundle.js
Copy link
Owner

@dyedgreen dyedgreen Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can look down permissions a bit more here?

--allow-run isn’t required, and we can scope reading to the repo and writing to just the bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants