-
Notifications
You must be signed in to change notification settings - Fork 108
Add js user agent client hints brand header-matching feature #4224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
959ce57
Add ua-ch-brands feature
laghee eeeb5d9
Lint
laghee 2485429
Add schema
laghee ab135de
Zap extraneous comments
laghee ec4abb3
Merge remote-tracking branch 'origin/main' into km/add-ua-ch-brands-feat
laghee 82a6f5b
Liiint
laghee c7e4657
Gate to internal & preview channels
laghee 9d3befa
Merge conditions into 1
laghee a1891b1
Fix angry test
laghee 8e28ce5
Experiment w/ swtiching syntax
laghee 3aa170b
Annnnd that was not the problem it seems
laghee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "_meta": { | ||
| "description": "User agent client hint brands for the browser JavaScript API." | ||
| }, | ||
| "state": "disabled", | ||
| "exceptions": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { CSSInjectFeatureSettings, Feature, FeatureState } from '../feature'; | ||
|
|
||
| type StateToggle = 'enabled' | 'disabled'; | ||
|
|
||
| type UaChBrandsSettings = CSSInjectFeatureSettings<{ | ||
| filterWebView2?: StateToggle; | ||
| overrideEdge?: StateToggle; | ||
| additionalCheck?: FeatureState; | ||
| }>; | ||
|
|
||
| export type UaChBrandsFeature<VersionType> = Feature<UaChBrandsSettings, VersionType>; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.