Skip to content

Conversation

@CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Nov 7, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211861342360907

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@CrisBarreiro CrisBarreiro changed the base branch from main to feature/cris/de-risk-adsjs/test-script-with-delayed-initial-ping-100 November 7, 2025 12:11
github-actions bot pushed a commit that referenced this pull request Nov 7, 2025
@CrisBarreiro CrisBarreiro added the DO NOT MERGE Don't merge this branch unless directed label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Generated file outputs:

Time updated: Thu, 13 Nov 2025 14:25:55 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/android-config.json
  • v4/android-config.json
--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -102650,9 +102650,9 @@
         "webViewCompat": {
             "state": "enabled",
             "exceptions": [],
             "settings": {
-                "jsInitialPingDelay": 100,
+                "jsInitialPingDelay": 20,
                 "initialPingDelay": 0
             },
             "features": {
                 "jsSendsInitialPing": {
latest
v5/android-config.json
--- v5/android-config.json
+++ v5/android-config.json
@@ -102650,9 +102650,9 @@
         "webViewCompat": {
             "state": "enabled",
             "exceptions": [],
             "settings": {
-                "jsInitialPingDelay": 100,
+                "jsInitialPingDelay": 20,
                 "initialPingDelay": 0
             },
             "features": {
                 "jsSendsInitialPing": {
13 files identical
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

JSON approval analysis:

Time updated: Thu, 13 Nov 2025 14:36:09 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/webViewCompat/settings/jsInitialPingDelay (replace)
  • v4/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/webViewCompat/settings/jsInitialPingDelay (replace)
latest

❌ Manual Review Required

  • v5/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/webViewCompat/settings/jsInitialPingDelay (replace)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

CDRussell
CDRussell previously approved these changes Nov 7, 2025
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/de-risk-adsjs/test-script-with-delayed-initial-ping-100 branch from 28b454a to 3221972 Compare November 13, 2025 14:06
Base automatically changed from feature/cris/de-risk-adsjs/test-script-with-delayed-initial-ping-100 to main November 13, 2025 14:13
@CrisBarreiro CrisBarreiro dismissed CDRussell’s stale review November 13, 2025 14:13

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Don't merge this branch unless directed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants