Fix up permissions API with non hardcoded values #1867

jonathanKingston · 2025-07-31T11:46:24Z

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209253361096901/task/1209488147924654?focus=true

Description

Fixes up the API with the current permission status rather than the new Chromium hardcoding they've added.
Adds a setting to allow us to control the rollout here.

Testing Steps

Checklist

Please tick all that apply:

I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged

Note

Implements native-aware Permissions handling (with fall-through to original API) and refactors/expands tests to cover both shimmed and existing Permissions APIs.

WebCompat (Permissions):
- Introduce shadow PermissionStatus class for shimming.
- Add handlePermissionQuery to message native for native-marked permissions and return PermissionStatus, else fall through.
- Add permissionsPresentFix to proxy existing navigator.permissions.query; gated by webCompat.permissionsPresent.
- Update permissionsFix to validate args, use shared handler, and default to 'prompt' when falling back.
Tests:
- Refactor with shared runner (createApiTestRunner), setup (setupPermissionsTest), helpers (checkPermission), and reusable cases (permissionsTestCases).
- Add suite for API present: ensures fall-through for non-native/unsupported/invalid inputs and interception for native permissions, including success/unexpected/error paths.
- Parameterize runs for API deleted vs shimmed; adjust disabled-feature checks accordingly.

^{Written by Cursor Bugbot for commit 6f4bc06. This will update automatically on new commits. Configure here.}

netlify · 2025-07-31T11:46:28Z

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	`6f4bc06`
🔍 Latest deploy log	https://app.netlify.com/projects/content-scope-scripts/deploys/692ec781e86be10008b2812e
😎 Deploy Preview	https://deploy-preview-1867--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-07-31T11:46:54Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1867
Commit Hash: 1b083a95bcb46ad3d0f1148c4cd82de814194f28
Last Updated: December 2, 2025 at 11:03:57 AM UTC
Install Command: npm i github:duckduckgo/content-scope-scripts#1b083a95bcb46ad3d0f1148c4cd82de814194f28

Please use the above install command to update to the latest version.

github-actions · 2025-07-31T11:47:24Z

[Beta] Generated file diff

Time updated: Tue, 02 Dec 2025 11:04:23 GMT

Android

    - android/adsjsContentScope.js

android/autofillImport.js
android/brokerProtection.js
android/contentScope.js

File has changed

Apple

    - apple/contentScope.js

apple/contentScopeIsolated.js
apple/pages/new-tab/dist/index.js
apple/pages/onboarding/dist/index.js

File has changed

Chrome-mv3

    - chrome-mv3/inject.js

File has changed

Firefox

    - firefox/inject.js

File has changed

Integration

    - integration/contentScope.js

integration/pages/new-tab/dist/index.js
integration/pages/onboarding/dist/index.js

File has changed

Windows

    - windows/contentScope.js

windows/pages/new-tab/dist/index.js
windows/pages/onboarding/dist/index.js

File has changed

nshuba

Changes look good, but it might be worth updating the integration tests? We have some basic ones for permissions APIs already.

Bumps [@rive-app/canvas-single](https://github.com/rive-app/rive-wasm) from 2.31.1 to 2.31.2. - [Changelog](https://github.com/rive-app/rive-wasm/blob/master/CHANGELOG.md) - [Commits](rive-app/rive-wasm@2.31.1...2.31.2) --- updated-dependencies: - dependency-name: "@rive-app/canvas-single" dependency-version: 2.31.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.25.8 to 0.25.9. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.25.8...v0.25.9) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.25.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add in file count check for data.files in canShare * Update check and tests * Lint fix

* Update build-and-troubleshooting.md for apple changes * Lint fix

* Auto approve patch changes to the repo * Lint fix * Ignore higher risk deps

* Ensure we check isFeatureEnabled correctly * Only trigger updates on listenForUpdateChanges enabled features (CTL) * Add bail out option for invalid messages

* Add additionalCheck for android rollout * Add test case * Simplify test case * Lint fix * Continue in the loop instead of return

* Add in file count check for data.files in canShare * Update check and tests * Lint fix * Make canShare more permissive

cursor · 2025-12-02T11:12:02Z

injected/integration-test/web-compat.spec.js

+        test('should default to prompt when native error occurs', async ({ page }) => {
+            await setupPermissionsTest(page, { removePermissions: removeApi });
+            await permissionsTestCases.testNativePermissionError(page);
+        });


Bug: Tests fail when API exists but permissionsPresent not enabled

The createApiTestRunner runs tests with removeApi: false ("with API shimmed"), but setupPermissionsTest doesn't enable permissionsPresent by default. When the browser's permissions API exists and permissionsPresent is not enabled, permissionsFix returns early without modifying anything (line 571-575 in web-compat.js). Tests like testNameOverride expect custom behavior (e.g., renaming push to notifications), but the browser's unchanged native API won't apply these overrides, causing test failures.

_{Please tell me if this was useful or not with a 👍 or 👎.}

Additional Locations (1)

injected/integration-test/web-compat.spec.js#L380-L382

jonathanKingston assigned dharb and nshuba Jul 31, 2025

jonathanKingston marked this pull request as ready for review July 31, 2025 11:58

jonathanKingston requested a review from a team as a code owner July 31, 2025 11:58

This comment was marked as outdated.

Sign in to view

jonathanKingston force-pushed the jkt/permissionAPIFix branch from 7a9e42e to dd1a57b Compare July 31, 2025 13:19

nshuba previously approved these changes Jul 31, 2025

View reviewed changes

jonathanKingston dismissed nshuba’s stale review via 4a29dfe July 31, 2025 17:51

This comment was marked as outdated.

Sign in to view

jonathanKingston added 6 commits August 15, 2025 23:26

Fix up permissions API with non hardcoded values

8ec2855

Fix up pr feedback

8ca790b

PoC test

121be96

Share between tests

46a282e

remove setup from all tests

c57c6c1

lint fix

43e46c7

jonathanKingston force-pushed the jkt/permissionAPIFix branch from afe85a6 to 43e46c7 Compare August 15, 2025 22:30

jonathanKingston and others added 10 commits August 18, 2025 12:17

Add fix for test

e63c9fe

Force search mode when Duck.ai is disabled in Omnibar (#1895)

9d31416

Add in file count check for data.files in canShare (#1899)

7d33f65

* Add in file count check for data.files in canShare * Update check and tests * Lint fix

Update build-and-troubleshooting.md for apple changes (#1891)

60f8e33

* Update build-and-troubleshooting.md for apple changes * Lint fix

Auto approve patch changes to the repo (#1904)

5a70d5b

* Auto approve patch changes to the repo * Lint fix * Ignore higher risk deps

Add @duckduckgo/extension-owners to CODEOWNERS (#1896)

0e3f662

Ensure message correctness in extension (#1907)

4fee508

* Ensure we check isFeatureEnabled correctly * Only trigger updates on listenForUpdateChanges enabled features (CTL) * Add bail out option for invalid messages

jonathanKingston added 3 commits August 21, 2025 16:27

Add additionalCheck for android rollout (#1908)

f749184

* Add additionalCheck for android rollout * Add test case * Simplify test case * Lint fix * Continue in the loop instead of return

Open up canShare some more (#1906)

a8010ef

* Add in file count check for data.files in canShare * Update check and tests * Lint fix * Make canShare more permissive

Disable constructor check for now and gate for native calls only

42f887f

jonathanKingston requested review from franfaccin, kzar, ladamski, mgurgel and shakyShane as code owners August 21, 2025 15:27

jonathanKingston added 5 commits August 21, 2025 16:28

Merge remote-tracking branch 'origin/main' into jkt/permissionAPIFix

866b8e4

Validate native only testing

ba4bee4

Add support for non .native handlers

6860c54

Switch based on API presence

a32023b

Merge branch 'main' into jkt/permissionAPIFix

6f4bc06

jonathanKingston enabled auto-merge December 2, 2025 11:03

jonathanKingston disabled auto-merge December 2, 2025 11:04

cursor bot reviewed Dec 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix up permissions API with non hardcoded values #1867

Fix up permissions API with non hardcoded values #1867

Uh oh!

jonathanKingston commented Jul 31, 2025 •

edited by cursor bot

Loading

Uh oh!

netlify bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

nshuba left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix up permissions API with non hardcoded values #1867

Are you sure you want to change the base?

Fix up permissions API with non hardcoded values #1867

Uh oh!

Conversation

jonathanKingston commented Jul 31, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Steps

Checklist

Uh oh!

netlify bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for content-scope-scripts ready!

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Temporary Branch Update

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Beta] Generated file diff

Uh oh!

This comment was marked as outdated.

Uh oh!

nshuba left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot Dec 2, 2025

Choose a reason for hiding this comment

Bug: Tests fail when API exists but permissionsPresent not enabled

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathanKingston commented Jul 31, 2025 •

edited by cursor bot

Loading

netlify bot commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Jul 31, 2025 •

edited

Loading