-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add NotAuthorizedPage to AuthorizeRouteView #64646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/add-forbidden-page-implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+204
−2
Draft
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
73e3d67
Initial plan
Copilot 1eaaede
Add ForbiddenPage support for Blazor Router and SSR endpoints
Copilot b4bdd85
Add unit tests for ForbiddenPage and Forbidden event
Copilot 0311790
Fix code review comment to clarify ForbiddenEventArgs.Path reference
Copilot 807aa9b
Redesign: Move ForbiddenPage to AuthorizeRouteView as NotAuthorizedPage
Copilot 1a6bcee
Add unit tests, E2E tests, and test infrastructure for NotAuthorizedPage
Copilot 0fa988e
Add IComponent validation and improve documentation for NotAuthorized…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,9 @@ | ||
| #nullable enable | ||
| Microsoft.AspNetCore.Components.NavigationManager.Forbidden() -> void | ||
| Microsoft.AspNetCore.Components.NavigationManager.OnForbidden -> System.EventHandler<Microsoft.AspNetCore.Components.Routing.ForbiddenEventArgs!>! | ||
| Microsoft.AspNetCore.Components.Routing.ForbiddenEventArgs | ||
| Microsoft.AspNetCore.Components.Routing.ForbiddenEventArgs.ForbiddenEventArgs() -> void | ||
| Microsoft.AspNetCore.Components.Routing.ForbiddenEventArgs.Path.get -> string? | ||
| Microsoft.AspNetCore.Components.Routing.ForbiddenEventArgs.Path.set -> void | ||
| Microsoft.AspNetCore.Components.Routing.Router.ForbiddenPage.get -> System.Type? | ||
| Microsoft.AspNetCore.Components.Routing.Router.ForbiddenPage.set -> void |
15 changes: 15 additions & 0 deletions
15
src/Components/Components/src/Routing/ForbiddenEventArgs.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Microsoft.AspNetCore.Components.Routing; | ||
|
|
||
| /// <summary> | ||
| /// <see cref="EventArgs" /> for <see cref="NavigationManager.OnForbidden" />. | ||
| /// </summary> | ||
| public sealed class ForbiddenEventArgs : EventArgs | ||
| { | ||
| /// <summary> | ||
| /// Gets the path of ForbiddenPage. If the path is set, it indicates that a subscriber has handled the rendering of the Forbidden contents. | ||
| /// </summary> | ||
| public string? Path { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. The router should not be involved in this feature. It should all be part of
AuthorizeRouteView. For starters we only want the ForbiddenPageType. We don't want a way to trigger Forbidden from Navigation manager.@copilot redesign the fix based on these constraints. You also need to add E2E tests for it. See src/Components/Agents.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redesigned the implementation based on your feedback. The feature is now solely in
AuthorizeRouteViewwith aNotAuthorizedPageproperty. All Router, NavigationManager, and endpoint changes have been reverted.Key changes (commit 0fa988e):
NotAuthorizedPageparameter toAuthorizeRouteViewthat renders a specified component when authorization fails