-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Blazor supports DisplayName for models
#64636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 9 commits
ba210fd
46795d5
a167497
60aa7f7
db4d8af
11da419
7bfb44c
dc39fdc
b048f80
ce68d5a
a8098f9
b6195cc
dfec213
5a4421f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.ComponentModel; | ||
| using System.ComponentModel.DataAnnotations; | ||
| using System.Linq.Expressions; | ||
| using System.Reflection; | ||
| using Microsoft.AspNetCore.Components.Rendering; | ||
|
|
||
| namespace Microsoft.AspNetCore.Components.Forms; | ||
|
|
||
| /// <summary> | ||
| /// Displays the display name for a specified field, reading from <see cref="DisplayAttribute"/> | ||
| /// or <see cref="DisplayNameAttribute"/> if present, or falling back to the property name. | ||
| /// </summary> | ||
| /// <typeparam name="TValue">The type of the field.</typeparam> | ||
| public class DisplayName<TValue> : ComponentBase | ||
| { | ||
| private Expression<Func<TValue>>? _previousFieldAccessor; | ||
| private string? _displayName; | ||
|
|
||
| /// <summary> | ||
| /// Specifies the field for which the display name should be shown. | ||
| /// </summary> | ||
| [Parameter, EditorRequired] | ||
| public Expression<Func<TValue>>? For { get; set; } | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override void OnParametersSet() | ||
| { | ||
| if (For is null) | ||
| { | ||
| throw new InvalidOperationException($"{GetType()} requires a value for the " + | ||
| $"{nameof(For)} parameter."); | ||
| } | ||
|
|
||
| if (For != _previousFieldAccessor) | ||
| { | ||
| _displayName = GetDisplayName(For); | ||
| _previousFieldAccessor = For; | ||
| } | ||
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| protected override void BuildRenderTree(RenderTreeBuilder builder) | ||
| { | ||
| builder.AddContent(0, _displayName); | ||
| } | ||
|
|
||
| private static string GetDisplayName(Expression<Func<TValue>> expression) | ||
| { | ||
| if (expression.Body is MemberExpression memberExpression) | ||
| { | ||
| var member = memberExpression.Member; | ||
|
|
||
| var displayAttribute = member.GetCustomAttribute<DisplayAttribute>(); | ||
| if (displayAttribute != null) | ||
| { | ||
| var name = displayAttribute.GetName(); | ||
| if (name != null) | ||
| { | ||
| return name; | ||
| } | ||
| } | ||
|
|
||
| var displayNameAttribute = member.GetCustomAttribute<DisplayNameAttribute>(); | ||
| if (displayNameAttribute?.DisplayName is not null) | ||
| { | ||
| return displayNameAttribute.DisplayName; | ||
| } | ||
|
|
||
| return member.Name; | ||
| } | ||
ilonatommy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| throw new ArgumentException( | ||
| $"The provided expression contains a {expression.Body.GetType().Name} which is not supported. " + | ||
| $"{nameof(DisplayNameLabel<TValue>)} only supports simple member accessors (fields, properties) of an object.", | ||
|
Check failure on line 77 in src/Components/Web/src/Forms/DisplayName.cs
|
||
| nameof(expression)); | ||
|
Check failure on line 78 in src/Components/Web/src/Forms/DisplayName.cs
|
||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,206 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.ComponentModel; | ||
| using System.ComponentModel.DataAnnotations; | ||
| using Microsoft.AspNetCore.Components.Rendering; | ||
| using Microsoft.AspNetCore.Components.Test.Helpers; | ||
|
|
||
| namespace Microsoft.AspNetCore.Components.Forms; | ||
|
|
||
| public class DisplayNameTest | ||
| { | ||
| [Fact] | ||
| public async Task ThrowsIfNoForParameterProvided() | ||
| { | ||
| // Arrange | ||
| var rootComponent = new TestHostComponent | ||
| { | ||
| InnerContent = builder => | ||
| { | ||
| builder.OpenComponent<DisplayName<string>>(0); | ||
| builder.CloseComponent(); | ||
| } | ||
| }; | ||
|
|
||
| var testRenderer = new TestRenderer(); | ||
| var componentId = testRenderer.AssignRootComponentId(rootComponent); | ||
|
|
||
| // Act & Assert | ||
| var ex = await Assert.ThrowsAsync<InvalidOperationException>( | ||
| async () => await testRenderer.RenderRootComponentAsync(componentId)); | ||
| Assert.Contains("For", ex.Message); | ||
| Assert.Contains("parameter", ex.Message); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task DisplaysPropertyNameWhenNoAttributePresent() | ||
| { | ||
| // Arrange | ||
| var model = new TestModel(); | ||
| var rootComponent = new TestHostComponent | ||
| { | ||
| InnerContent = builder => | ||
| { | ||
| builder.OpenComponent<DisplayName<string>>(0); | ||
| builder.AddComponentParameter(1, "For", (System.Linq.Expressions.Expression<Func<string>>)(() => model.PlainProperty)); | ||
| builder.CloseComponent(); | ||
| } | ||
| }; | ||
|
|
||
| // Act | ||
| var output = await RenderAndGetOutput(rootComponent); | ||
|
|
||
| // Assert | ||
| Assert.Equal("PlainProperty", output); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task DisplaysDisplayAttributeName() | ||
| { | ||
| // Arrange | ||
| var model = new TestModel(); | ||
| var rootComponent = new TestHostComponent | ||
| { | ||
| InnerContent = builder => | ||
| { | ||
| builder.OpenComponent<DisplayName<string>>(0); | ||
| builder.AddComponentParameter(1, "For", (System.Linq.Expressions.Expression<Func<string>>)(() => model.PropertyWithDisplayAttribute)); | ||
| builder.CloseComponent(); | ||
| } | ||
| }; | ||
|
|
||
| // Act | ||
| var output = await RenderAndGetOutput(rootComponent); | ||
|
|
||
| // Assert | ||
| Assert.Equal("Custom Display Name", output); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task DisplaysDisplayNameAttributeName() | ||
| { | ||
| // Arrange | ||
| var model = new TestModel(); | ||
| var rootComponent = new TestHostComponent | ||
| { | ||
| InnerContent = builder => | ||
| { | ||
| builder.OpenComponent<DisplayName<string>>(0); | ||
| builder.AddComponentParameter(1, "For", (System.Linq.Expressions.Expression<Func<string>>)(() => model.PropertyWithDisplayNameAttribute)); | ||
| builder.CloseComponent(); | ||
| } | ||
| }; | ||
|
|
||
| // Act | ||
| var output = await RenderAndGetOutput(rootComponent); | ||
|
|
||
| // Assert | ||
| Assert.Equal("Custom DisplayName", output); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task DisplayAttributeTakesPrecedenceOverDisplayNameAttribute() | ||
| { | ||
| // Arrange | ||
| var model = new TestModel(); | ||
| var rootComponent = new TestHostComponent | ||
| { | ||
| InnerContent = builder => | ||
| { | ||
| builder.OpenComponent<DisplayName<string>>(0); | ||
| builder.AddComponentParameter(1, "For", (System.Linq.Expressions.Expression<Func<string>>)(() => model.PropertyWithBothAttributes)); | ||
| builder.CloseComponent(); | ||
| } | ||
| }; | ||
|
|
||
| // Act | ||
| var output = await RenderAndGetOutput(rootComponent); | ||
|
|
||
| // Assert | ||
| // DisplayAttribute should take precedence per MVC conventions | ||
| Assert.Equal("Display Takes Precedence", output); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task WorksWithDifferentPropertyTypes() | ||
| { | ||
| // Arrange | ||
| var model = new TestModel(); | ||
| var intComponent = new TestHostComponent | ||
| { | ||
| InnerContent = builder => | ||
| { | ||
| builder.OpenComponent<DisplayName<int>>(0); | ||
| builder.AddComponentParameter(1, "For", (System.Linq.Expressions.Expression<Func<int>>)(() => model.IntProperty)); | ||
| builder.CloseComponent(); | ||
| } | ||
| }; | ||
| var dateComponent = new TestHostComponent | ||
| { | ||
| InnerContent = builder => | ||
| { | ||
| builder.OpenComponent<DisplayName<DateTime>>(0); | ||
| builder.AddComponentParameter(1, "For", (System.Linq.Expressions.Expression<Func<DateTime>>)(() => model.DateProperty)); | ||
| builder.CloseComponent(); | ||
| } | ||
| }; | ||
|
|
||
| // Act | ||
| var intOutput = await RenderAndGetOutput(intComponent); | ||
| var dateOutput = await RenderAndGetOutput(dateComponent); | ||
|
|
||
| // Assert | ||
| Assert.Equal("Integer Value", intOutput); | ||
| Assert.Equal("Date Value", dateOutput); | ||
| } | ||
|
|
||
| private static async Task<string> RenderAndGetOutput(TestHostComponent rootComponent) | ||
| { | ||
| var testRenderer = new TestRenderer(); | ||
| var componentId = testRenderer.AssignRootComponentId(rootComponent); | ||
| await testRenderer.RenderRootComponentAsync(componentId); | ||
|
|
||
| var batch = testRenderer.Batches.Single(); | ||
| var displayLabelComponentFrame = batch.ReferenceFrames | ||
| .First(f => f.FrameType == RenderTree.RenderTreeFrameType.Component && | ||
| f.Component is DisplayName<string> or DisplayName<int> or DisplayName<DateTime>); | ||
|
|
||
| // Find the text content frame within the component | ||
| var textFrame = batch.ReferenceFrames | ||
| .First(f => f.FrameType == RenderTree.RenderTreeFrameType.Text); | ||
|
|
||
| return textFrame.TextContent; | ||
| } | ||
|
|
||
| private class TestHostComponent : ComponentBase | ||
| { | ||
| public RenderFragment InnerContent { get; set; } | ||
|
|
||
| protected override void BuildRenderTree(RenderTreeBuilder builder) | ||
| { | ||
| InnerContent(builder); | ||
| } | ||
| } | ||
|
|
||
| private class TestModel | ||
| { | ||
| public string PlainProperty { get; set; } = string.Empty; | ||
|
|
||
| [Display(Name = "Custom Display Name")] | ||
| public string PropertyWithDisplayAttribute { get; set; } = string.Empty; | ||
|
|
||
| [DisplayName("Custom DisplayName")] | ||
| public string PropertyWithDisplayNameAttribute { get; set; } = string.Empty; | ||
|
|
||
| [Display(Name = "Display Takes Precedence")] | ||
| [DisplayName("This Should Not Be Used")] | ||
| public string PropertyWithBothAttributes { get; set; } = string.Empty; | ||
|
|
||
| [Display(Name = "Integer Value")] | ||
| public int IntProperty { get; set; } | ||
|
|
||
| [Display(Name = "Date Value")] | ||
| public DateTime DateProperty { get; set; } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| @using System.ComponentModel | ||
| @using System.ComponentModel.DataAnnotations | ||
| @using Microsoft.AspNetCore.Components.Forms | ||
|
|
||
| <div> | ||
| <p id="product-name-label"><DisplayName For="@(() => _product.Name)" /></p> | ||
| <p id="price-label"><DisplayName For="@(() => _product.Price)" /></p> | ||
| <p id="stock-label"><DisplayName For="@(() => _product.StockQuantity)" /></p> | ||
| <p id="description-label"><DisplayName For="@(() => _product.Description)" /></p> | ||
| </div> | ||
|
|
||
| @code { | ||
| private Product _product = new Product(); | ||
|
|
||
| class Product | ||
| { | ||
| [Display(Name = "Product Name")] | ||
| public string Name { get; set; } = "Sample"; | ||
|
|
||
| [DisplayName("Unit Price")] | ||
| public decimal Price { get; set; } = 99.99m; | ||
|
|
||
| [Display(Name = "Stock Quantity")] | ||
| [DisplayName("Stock Amount")] // This should be ignored, Display takes precedence | ||
| public int StockQuantity { get; set; } = 100; | ||
|
|
||
| // No attributes - should fall back to property name | ||
| public string Description { get; set; } = "Test"; | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.