Skip to content

Dispose stream in initializer if loading file fails #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
twsouthwick merged 1 commit into from
Nov 20, 2024
Merged

Dispose stream in initializer if loading file fails #1829

twsouthwick merged 1 commit into from
Nov 20, 2024

Conversation

@twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Nov 19, 2024

Fixes #1681

@github-actions
Copy link

github-actions bot commented Nov 20, 2024

Test Results

    70 files  ± 0      70 suites  ±0   1h 8m 31s ⏱️ + 3m 8s
 2 039 tests + 3   2 036 ✅ + 3   3 💤 ±0  0 ❌ ±0 
32 394 runs  +36  32 358 ✅ +36  36 💤 ±0  0 ❌ ±0 

Results for commit 53efb3c. ± Comparison against base commit b515e91.

@twsouthwick twsouthwick enabled auto-merge (squash) November 20, 2024 00:43
@twsouthwick twsouthwick merged commit 1c165bd into main Nov 20, 2024
22 checks passed
@twsouthwick twsouthwick deleted the dispose-stream-invalid-file branch November 20, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomjebo tomjebo tomjebo approved these changes

@mikeebowen mikeebowen mikeebowen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug with opening corrupted Open XML documents

4 participants

@twsouthwick @tomjebo @mikeebowen