-
Notifications
You must be signed in to change notification settings - Fork 25.1k
[11.0 P1] Forms on BLazor support DisplayName attribute
#36438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
guardrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ilonatommy ... Approving with tiny NITs.
I'll take care of the release notes. I'll ping you on that PR when it goes up within the next few days.
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
|
@ilonatommy I've opened a new pull request, #36445, to work on those changes. Once the pull request is ready, I'll request review from you. |
guardrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with just one NIT on a colon.
LGTM ... and I'll have the release notes for this and the startup options format up on GH shortly ... will ping u for review.
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
Doc changes proposal for dotnet/aspnetcore#64636.
Issue: dotnet/aspnetcore#49147
Internal previews