[no-release-notes] Add cost estimates to GroupBy, Sort, HashLookup, SubqueryAlias, and Case nodes in plan tests #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
force-pushed
the
nicktobey/describe
branch
2 times, most recently
from
b8c3a83 to
628f6d4
Compare
nicktobey
force-pushed
the
nicktobey/describe
branch
from
628f6d4 to
6fe1546
Compare
nicktobey
changed the title
nicktobey
force-pushed
the
nicktobey/describe
branch
from
548b5e0 to
0e8a922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These nodes previously didn't implement the Describable interface, which is used for displaying cost and row estimates in plan tests. While these nodes themselves don't contain estimates, their children might, and implementing the interface ensures that estimates are generated for those children nodes.