-
Notifications
You must be signed in to change notification settings - Fork 74
chore(deps): bump the go-modules-root group across 1 directory with 3 updates #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump the go-modules-root group across 1 directory with 3 updates #533
Conversation
… updates Bumps the go-modules-root group with 2 updates in the / directory: [github.com/containerd/containerd/v2](https://github.com/containerd/containerd) and [github.com/jaypipes/ghw](https://github.com/jaypipes/ghw). Updates `github.com/containerd/containerd/v2` from 2.1.5 to 2.2.0 - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v2.1.5...v2.2.0) Updates `github.com/containerd/platforms` from 1.0.0-rc.1 to 1.0.0-rc.2 - [Release notes](https://github.com/containerd/platforms/releases) - [Commits](containerd/platforms@v1.0.0-rc.1...v1.0.0-rc.2) Updates `github.com/jaypipes/ghw` from 0.19.1 to 0.21.1 - [Release notes](https://github.com/jaypipes/ghw/releases) - [Commits](jaypipes/ghw@v0.19.1...v0.21.1) --- updated-dependencies: - dependency-name: github.com/containerd/containerd/v2 dependency-version: 2.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-modules-root - dependency-name: github.com/containerd/platforms dependency-version: 1.0.0-rc.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-modules-root - dependency-name: github.com/jaypipes/ghw dependency-version: 0.21.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-modules-root ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Summary of ChangesHello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's dependencies and build environment by updating the Go language version to 1.24.3 and refreshing numerous Go module dependencies. A significant improvement is also made to the automated script responsible for synchronizing the Go version across various project files, now extending its coverage to include GitHub Actions workflow configurations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue, and left some high level feedback:
- The
sync-go-version.shworkflow handling assumes simplego-version: <version>lines; if you ever usematrixor list syntax forgo-version, the currentgrep/sedpatterns will either miss them or rewrite them incorrectly, so consider making the match/update logic robust to those common patterns. - In
sync-go-version.sh, thegrep ... | head -1 | xargspipeline incheck_filewill collapse internal whitespace and strip leading/trailing spaces from the matched line, which can make the reportedhave:line differ from the actual file content; if you care about preserving formatting in the output, dropxargsor replace it with a less aggressive trimmer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `sync-go-version.sh` workflow handling assumes simple `go-version: <version>` lines; if you ever use `matrix` or list syntax for `go-version`, the current `grep`/`sed` patterns will either miss them or rewrite them incorrectly, so consider making the match/update logic robust to those common patterns.
- In `sync-go-version.sh`, the `grep ... | head -1 | xargs` pipeline in `check_file` will collapse internal whitespace and strip leading/trailing spaces from the matched line, which can make the reported `have:` line differ from the actual file content; if you care about preserving formatting in the output, drop `xargs` or replace it with a less aggressive trimmer.
## Individual Comments
### Comment 1
<location> `scripts/sync-go-version.sh:71` </location>
<code_context>
if ! grep -q "$expected_pattern" "$file"; then
local current
- current=$(grep "$search_pattern" "$file" 2>/dev/null | head -1 || echo "(not found)")
+ current=$(grep "$search_pattern" "$file" 2>/dev/null | head -1 | xargs || echo "(not found)")
echo "Mismatch: $(realpath "$file")"
echo " have: $current"
</code_context>
<issue_to_address>
**issue (bug_risk):** The new pipeline for `current` never yields "(not found)" when the pattern is missing.
Because `head` and `xargs` both exit 0 even with no input, the `|| echo "(not found)"` fallback is never triggered in this new pipeline. As a result, `current` becomes an empty string instead of "(not found)", which changes the previous behavior and can make the mismatch output ambiguous.
To keep the original semantics while still trimming whitespace, you could, for example:
```bash
current=$(grep "$search_pattern" "$file" 2>/dev/null | head -1 || echo "(not found)")
current=$(echo "$current" | xargs)
```
or:
```bash
current=$(grep "$search_pattern" "$file" 2>/dev/null | head -1)
current=${current:-"(not found)"}
current=$(echo "$current" | xargs)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily bumps the Go version and several dependencies across the repository. The included improvements to the sync-go-version.sh script, which now also handles GitHub workflow files, are a welcome addition for maintaining consistency. The changes are generally well-implemented, but I've identified a minor issue in the script's new logic that could be improved for better robustness.
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
c3278f6 to
2b9bd52
Compare
Fixes/split from #508.
go.mod.