Skip to content

Conversation

@htoyoda18
Copy link
Contributor

@htoyoda18 htoyoda18 commented Dec 20, 2025

What I did
I updated the timeout initialization logic to only set a time.Duration value when waitTimeout is greater than zero.

Previously, the timeout was always calculated, even when waitTimeout was zero or a negative value. This could unintentionally override the default behavior or result in an invalid timeout being applied.

With this change, the timeout is now explicitly guarded:

  • The default behavior is preserved when waitTimeout is unset or zero
  • Negative values are safely ignored, preventing unintended or invalid timeout configurations

This makes the behavior more explicit and defensive.

Related issue

N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did
A small guard to prevent unintended behavior 🐶
dogs

Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
@htoyoda18 htoyoda18 marked this pull request as ready for review December 20, 2025 07:16
@htoyoda18 htoyoda18 requested a review from a team as a code owner December 20, 2025 07:16
@htoyoda18 htoyoda18 requested review from glours and ndeloof December 20, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant