Fix timeout initialization when waitTimeout is zero #13471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I updated the timeout initialization logic to only set a
time.Durationvalue when waitTimeout is greater than zero.Previously, the timeout was always calculated, even when
waitTimeoutwas zero or a negative value. This could unintentionally override the default behavior or result in an invalid timeout being applied.With this change, the timeout is now explicitly guarded:
waitTimeoutis unset or zeroThis makes the behavior more explicit and defensive.
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did

A small guard to prevent unintended behavior 🐶