add service name completion to down command #13470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Robin Aumann-O'Keefe <jan-robin@aumann.org>
bmo-at
force-pushed
the
13469-suggest-service-names-on-docker-compose-down
branch
from
ec43eb1 to
8c55067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I reused the function defined in
compose/cmd/compose/completion.go
Line 39 in bd05d60
and added it to the the validation function for the down command here:
compose/cmd/compose/down.go
Line 63 in bd05d60
Related issue
This closes the feature request #13469, purely coincidentally :)
A picture of a cute animal, if possible in relation to what you did
Enjoy this very unrelated gif of my dog Sadie asking you to please approve this PR (she frequently only wants to shut down one specific one of the services in her docker compose projects):
