Skip to content

[28.x backport] remove aliases for containerd/errdefs, disallow docker/errdefs #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
austinvazquez merged 1 commit into from
Aug 16, 2025
Merged

[28.x backport] remove aliases for containerd/errdefs, disallow docker/errdefs #6272

austinvazquez merged 1 commit into from
Aug 16, 2025

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 15, 2025 •
edited
Loading

@thaJeztah thaJeztah added this to the 28.4.0 milestone Aug 15, 2025
@thaJeztah thaJeztah mentioned this pull request Aug 15, 2025
Merged
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 33.23699% with 231 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/registry/config.go 62.26% 55 Missing and 5 partials ⚠️
internal/registry/service.go 0.00% 41 Missing ⚠️
internal/registry/service_v2.go 0.00% 24 Missing ⚠️
cli/command/registry/search.go 0.00% 16 Missing ⚠️
cli/registry/client/endpoint.go 0.00% 14 Missing ⚠️
internal/registry/errors.go 30.00% 14 Missing ⚠️
cli/trust/trust.go 0.00% 10 Missing ⚠️
internal/registry/registry.go 0.00% 9 Missing ⚠️
internal/registry/auth.go 0.00% 7 Missing ⚠️
cli/command/plugin/push.go 0.00% 6 Missing ⚠️
... and 13 more

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah force-pushed the 28.x_backport_errdefs_unalias branch from b4e0c6d to 0b36cf7 Compare August 15, 2025 13:46
@thaJeztah
remove aliases for containerd/errdefs, disallow docker/errdefs
034dc93 
We transitioned most functionality of docker/errdefs to containerd
errdefs module, and the docker/errdefs package should no longer be
used.

Because of that, there will no longer be ambiguity, so we can remove
the aliases for this package, and use it as "errdefs".

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 89d8c8a)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 28.x_backport_errdefs_unalias branch from 0b36cf7 to 034dc93 Compare August 16, 2025 16:29
@thaJeztah thaJeztah marked this pull request as ready for review August 16, 2025 16:29
@thaJeztah thaJeztah requested review from a team and silvin-lubecki as code owners August 16, 2025 16:29
@austinvazquez austinvazquez merged commit a8fe4aa into docker:28.x Aug 16, 2025
157 of 159 checks passed
@thaJeztah thaJeztah deleted the 28.x_backport_errdefs_unalias branch August 17, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austinvazquez austinvazquez austinvazquez approved these changes

@silvin-lubecki silvin-lubecki Awaiting requested review from silvin-lubecki silvin-lubecki is a code owner

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

28.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @codecov-commenter @austinvazquez